Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: silence_monitors config still emits a message on complete #1648

Open
2 tasks done
dagardner-nv opened this issue Apr 19, 2024 · 0 comments
Open
2 tasks done

[BUG]: silence_monitors config still emits a message on complete #1648

dagardner-nv opened this issue Apr 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.03

Which installation method(s) does this occur on?

Source

Describe the bug.

Setting silence_monitors=True still creates a MRC node, the mapped function is stubbed out due to using SilentMorpheusTqdm however the on_completed method is still invoked which produces a log.

Consider not adding any MRC nodes, which avoids the unnecessary GIL & Python conversions for the stubbed out stage.

Minimum reproducible example

No response

Relevant log output

Click here to see error details

[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant