Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Update LLMService to allow dynamic instantiation #1630

Closed
2 tasks done
shawn-davis opened this issue Apr 16, 2024 · 1 comment · Fixed by #1631
Closed
2 tasks done

[FEA]: Update LLMService to allow dynamic instantiation #1630

shawn-davis opened this issue Apr 16, 2024 · 1 comment · Fixed by #1631
Assignees
Labels
feature request New feature or request

Comments

@shawn-davis
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Change

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

I want to be able to instantiate LLM services/clients dynamically, so that models can be swapped out with command line arguments or config files instead of having to refactor pipeline code.

Describe your ideal solution

llm_service = LLMService.create(service, **service_kwargs)
llm_client = llm_service.get_client(**model_kwargs)

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@shawn-davis shawn-davis added the feature request New feature or request label Apr 16, 2024
@shawn-davis shawn-davis self-assigned this Apr 16, 2024
@jarmak-nv jarmak-nv moved this from Todo to Review - Ready for Review in Morpheus Boards Apr 16, 2024
mdemoret-nv added a commit that referenced this issue Apr 22, 2024
## Description
Adds the ability to instantiate LLM services/clients dynamically, so
that models can be swapped out with command line arguments or config
files instead of having to refactor pipeline code.
Closes #1630 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing
Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these
changes.
- When the PR is ready for review, the documentation is up to date with
these changes.
@mdemoret-nv
Copy link
Contributor

Closing as this is currently possible with LLMService.create(**kwargs)

@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants