Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Support ControlMessage types for Preprocess and Postprocess stages #1611

Closed
20 tasks done
yczhang-nv opened this issue Apr 10, 2024 · 0 comments · Fixed by #1623
Closed
20 tasks done

[FEA]: Support ControlMessage types for Preprocess and Postprocess stages #1611

yczhang-nv opened this issue Apr 10, 2024 · 0 comments · Fixed by #1623
Assignees
@yczhang-nv
Labels
feature request New feature or request

Comments

@yczhang-nv
Copy link
Contributor

yczhang-nv commented Apr 10, 2024 •
edited
Loading

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

Some of the PreprocessStage and PostprocessStage do not accept ControlMessage as their input data type.

Describe your ideal solution

As we move more stages to support ControlMessage, these stages should follow suite. All functionality should remain constant, only the supported data type will change.
Requires ControlMessage to be updated first: #1625

Completion Criteria

  • The PreprocessAEStage is updated to accept ControlMessage in addition to MultiMessage
    • The implementation has been updated to support ControlMessage
    • Unit tests and documentation have been updated
  • The FilterDetectionStage is updated to accept ControlMessage in addition to MultiMessage
    • The implementation has been updated to support ControlMessage
    • Unit tests and documentation have been updated
  • The GenerateVizFrameStage is updated to accept ControlMessage in addition to MultiMessage
    • The implementation has been updated to support ControlMessage
    • Unit tests and documentation have been updated
  • The MLFlowDriftStage is updated to accept ControlMessage in addition to MultiMessage
    • The implementation has been updated to support ControlMessage
    • Unit tests and documentation have been updated
  • The TimeSeriesStage is updated to accept ControlMessage in addition to MultiMessage
    • The implementation has been updated to support ControlMessage
    • Unit tests and documentation have been updated
  • The ValidationStage is updated to accept ControlMessage in addition to MultiMessage
    • The implementation has been updated to support ControlMessage
    • Unit tests and documentation have been updated

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@yczhang-nv yczhang-nv added the feature request New feature or request label Apr 10, 2024
@yczhang-nv yczhang-nv self-assigned this Apr 10, 2024
@yczhang-nv yczhang-nv linked a pull request May 10, 2024 that will close this issue
Support ControlMessage for Preprocess and PostProcess stages #1623
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yczhang-nv yczhang-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support ControlMessage for Preprocess and PostProcess stages yczhang-nv/Morpheus
1 participant
@yczhang-nv