Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Add DOCA libraries to CI runner to support testing and linting DOCA components in CI #1608

Closed
2 of 5 tasks
mdemoret-nv opened this issue Apr 9, 2024 · 0 comments · Fixed by #1622
Closed
2 of 5 tasks

[FEA]: Add DOCA libraries to CI runner to support testing and linting DOCA components in CI #1608

mdemoret-nv opened this issue Apr 9, 2024 · 0 comments · Fixed by #1622
Assignees
@cwharris
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

When changes are made to the DOCA C++ components in Morpheus, CI has no way of compiling these changes which is necessary to run tools like clang-tidy and IWYU. It is unable to compile these components because it is missing the DOCA libraries necessary for compilation.

Describe your ideal solution

The required libraries for DOCA compilation should be added to the CI runner container. While full testing of DOCA would require specific hardware, this will allow linting and basic unit tests to be performed in CI.

Completion Criteria

  • DOCA libraries are added to the CI runner and new runner images have been pushed
  • Add a few small unit tests for DOCA source stages to ensure they can be tested in CI
  • Update the CI runner documentation to indicate the changes and how to build new images

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@mdemoret-nv mdemoret-nv added the feature request New feature or request label Apr 9, 2024
@cwharris cwharris mentioned this issue Apr 11, 2024
Merged
@jarmak-nv jarmak-nv moved this from Todo to Review - Ready for Review in Morpheus Boards Apr 11, 2024
rapids-bot bot pushed a commit that referenced this issue May 29, 2024
@cwharris
Update CI to install DOCA and build Morpheus DOCA components. (#1622)
ca14433 
Closes #1608
Updates CI to install DOCA and build Morpheus DOCA components.

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Christopher Harris (https://github.com/cwharris)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1622
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwharris cwharris

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CI to install DOCA and build Morpheus DOCA components. cwharris/Morpheus
2 participants
@cwharris @mdemoret-nv