Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: DFP integrated training batch pipeline ignores --start_time flag #1590

Closed
2 tasks done
dagardner-nv opened this issue Apr 3, 2024 · 0 comments · Fixed by #1592
Closed
2 tasks done

[BUG]: DFP integrated training batch pipeline ignores --start_time flag #1590

dagardner-nv opened this issue Apr 3, 2024 · 0 comments · Fixed by #1592
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.06

Which installation method(s) does this occur on?

Source

Describe the bug.

dfp_integrated_training_batch_pipeline.py appears to be ignoring the --start_time flag.

Passing in --start_time "2022-08-08" still yields this output:

Preprocessed 102 data logs in 2022-08-02T00:37:03.000000000 to 2022-08-02T23:30:48.000000000 in 224.7006893157959 ms
Preprocessed 100 data logs in 2022-08-03T00:01:48.000000000 to 2022-08-03T23:58:52.000000000 in 193.61233711242676 ms

Minimum reproducible example

python dfp_duo_pipeline.py --train_users generic --start_time "2022-08-01" --input_file="../../../data/dfp/duo-training-data/*.json" --log_level=DEBUG --tracking_uri="http://localhost:5000"

Relevant log output

Click here to see error details
Preprocessed 102 data logs in 2022-08-02T00:37:03.000000000 to 2022-08-02T23:30:48.000000000 in 224.7006893157959 ms

Preprocessed 100 data logs in 2022-08-03T00:01:48.000000000 to 2022-08-03T23:58:52.000000000 in 193.61233711242676 ms

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Apr 3, 2024
@dagardner-nv dagardner-nv mentioned this issue Apr 4, 2024
Merged
@rapids-bot rapids-bot bot closed this as completed in #1592 Apr 5, 2024
rapids-bot bot pushed a commit that referenced this issue Apr 5, 2024
@dagardner-nv
Serialize datetime objects into the module config (#1592)
eaba5bb 
* Fixes an issue where the `--start_time` flag was being ignored
* Prior to nv-morpheus/MRC#451 the `datetime` objects being stored in the config were being serialized to json null, after that change an exception was raised.

Closes #1590

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1592
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialize datetime objects into the module config dagardner-nv/Morpheus
1 participant
@dagardner-nv