Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: DFP file_batcher module does not allow override of all default batching_options with control message #1577

Closed
2 tasks done
efajardo-nv opened this issue Mar 22, 2024 · 0 comments · Fixed by #1580
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@efajardo-nv
Copy link
Contributor

efajardo-nv commented Mar 22, 2024

Version

23.11

Which installation method(s) does this occur on?

Conda

Describe the bug.

  • In FileBatcher, the iso_date_regex object is created based on the configuration value retrieved at the start of the loader (code is displayed in 5).
  • This happens before the batching_options are merged.
def build_processing_params(control_message) -> typing.Dict[any, any]:
        batching_opts = {}
        if (control_message.has_metadata("batching_options")):
            batching_opts = control_message.get_metadata("batching_options")

        return merge_dictionaries(batching_opts, default_batching_opts)

As a result, any batching_options set in the input control message or in are not reflected at runtime.

Minimum reproducible example

No response

Relevant log output

Click here to see error details

[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@efajardo-nv efajardo-nv added the bug Something isn't working label Mar 22, 2024
@jarmak-nv jarmak-nv moved this from Todo to Review - Ready for Review in Morpheus Boards Mar 25, 2024
@rapids-bot rapids-bot bot closed this as completed in 1fc9588 Mar 27, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant