Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Support ControlMessage types for PreprocessNLPStage and PreprocessFILStage #1546

Closed
16 tasks done
mdemoret-nv opened this issue Mar 5, 2024 · 0 comments · Fixed by #1573
Closed
16 tasks done
Assignees
Labels
feature request New feature or request

Comments

@mdemoret-nv
Copy link
Contributor

mdemoret-nv commented Mar 5, 2024

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

Its currently not possible to use the PreprocessNLPStage or PreprocessFILStage with ControlMessage data types.

Describe your ideal solution

As we move more stages to support ControlMessage, these stages should follow suite. All functionality should remain constant, only the supported data type will change.

Completion Criteria

The following should be completed in order to consider this issue "Done":

  • The PreprocessNLPStage is updated to accept ControlMessage in addition to MultiMessage
    • The python implementation has been updated to support ControlMessage
    • The C++ implementation has been updated to support ControlMessage
  • The PreprocessFILStage is updated to accept ControlMessage in addition to MultiMessage
    • The python implementation has been updated to support ControlMessage
    • The C++ implementation has been updated to support ControlMessage
  • Unit tests have been added to exercise the new ControlMessage path for PreprocessNLPStage
    • Including a test to verify the C++ and Python implementations generate identical results
    • Including a test to verify the ControlMessage and MultiMessage implementations generate identical results
  • Unit tests have been added to exercise the new ControlMessage path for PreprocessFILStage
    • Including a test to verify the C++ and Python implementations generate identical results
    • Including a test to verify the ControlMessage and MultiMessage implementations generate identical results
  • Documentation for the PreprocessNLPStage has been updated to include the new supported data type
  • Documentation for the PreprocessFILStage has been updated to include the new supported data type

Additional context

Some of the requested changes may have already been implemented in PR #1454. However, some test and documentation may still be missing.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@mdemoret-nv mdemoret-nv added the feature request New feature or request label Mar 5, 2024
@mdemoret-nv mdemoret-nv moved this from Todo to In Progress in Morpheus Boards Mar 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Morpheus Boards Apr 5, 2024
@yczhang-nv yczhang-nv reopened this Apr 5, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Morpheus Boards Apr 5, 2024
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Apr 6, 2024
@rapids-bot rapids-bot bot closed this as completed in #1573 Apr 7, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
2 participants