[BUG]: stop() called twice for each stage on Control-C
#1477
Assignees
Labels
bug
Something isn't working
Comments
2 tasks
rapids-bot bot
pushed a commit
that referenced
this issue
Feb 15, 2024
… all stages (#1479) 1. Removes the `_is_built`, `_is_started` and `_is_stopped` flags and replaces with single member which holds onto the state enum for: INITIALIZED, BUILT, STARTED, STOPPED, COMPLETED 1. Changes the meaning of `stop()` and the meaning of `join()` for stages 1. `stop()` called 0 or 1 times. Only way it can get called is if `pipeline.stop()` was called indicating the pipeline should try to shut down gracefully. 1. Users should only implement this method if they have a source stage (or sources in their stage) 1. `join()` called exactly 1 time. Only called when the pipeline is complete and all stages are shut down. This is where users should implement any cleanup code 1. Tests for handling all of these scenarios with the pipeline. Closes #1477 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - Eli Fajardo (https://github.com/efajardo-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1479
github-project-automation
bot
moved this from Review - Ready for Review
to Done
in Morpheus Boards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
23.07
Which installation method(s) does this occur on?
Conda
Describe the bug.
When using
Control-Cto stop a pipeline, the stop() method on each stage is being called twice.Minimum reproducible example
Set up debug environment for Production DFP pipeline examples:
https://github.com/nv-morpheus/Morpheus/tree/branch-24.03/examples/digital_fingerprinting/production
Add breakpoint here:
https://github.com/nv-morpheus/Morpheus/blob/branch-24.03/morpheus/pipeline/stage_base.py#L448
Run any of the example pipelines.
Send SIGINT (Ctrl-C) to pipeline process.
Observe with breakpoint that stages are looped through twice to call stop().
Relevant log output
No response
Full env printout
No response
Other/Misc.
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: