Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: RSSController performs redundant fetches #1419

Closed
2 tasks done
dagardner-nv opened this issue Dec 8, 2023 · 0 comments · Fixed by #1442
Closed
2 tasks done

[BUG]: RSSController performs redundant fetches #1419

dagardner-nv opened this issue Dec 8, 2023 · 0 comments · Fixed by #1442
Assignees
@bsuryadevara
Labels
bug Something isn't working sherlock Issues/PRs related to Sherlock workflows and components
Milestone
24.03 - Sherlock ...

Comments

@dagardner-nv
Copy link
Contributor

Version

24.03

Which installation method(s) does this occur on?

Source

Describe the bug.

When feedparser fails to parse the feed, the controller falls back to parsing with beautiful soup.

However when falling back to parsing with beautiful soup a re-fetch is performed.

Minimum reproducible example

No response

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Dec 8, 2023
@mdemoret-nv mdemoret-nv added the sherlock Issues/PRs related to Sherlock workflows and components label Dec 8, 2023
@bsuryadevara bsuryadevara self-assigned this Dec 15, 2023
@bsuryadevara bsuryadevara moved this from Todo to In Progress in Morpheus Boards Dec 17, 2023
@bsuryadevara bsuryadevara mentioned this issue Dec 18, 2023
Merged
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Dec 18, 2023
rapids-bot bot pushed a commit that referenced this issue Jan 22, 2024
@bsuryadevara
Eliminate Redundant Fetches in RSS Controller (#1442)
659e735 
Addressed redundant feed fetches in the RSS Controller when parsing manually with BeautifulSoup and cache is enabled.

Closes #1419 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Bhargav Suryadevara (https://github.com/bsuryadevara)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1442
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsuryadevara bsuryadevara

Labels
bug Something isn't working sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Status: Done
Milestone
24.03 - Sherlock Improvements
3 participants
@bsuryadevara @mdemoret-nv @dagardner-nv