Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Disabling the pybind11 auto-generated signatures causes stubgen to not generate signatures for LLMNode #1331

Closed
2 tasks done
dagardner-nv opened this issue Nov 1, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

23.11

Which installation method(s) does this occur on?

Source

Describe the bug.

The auto-generated signatures for the overloaded method LLMNode::add_node cause a sphinx build error.

I disabled this for that class with:

// The auto-generated docstrings for the overloaded function in this class cause sphinx errors
py::options options;
options.disable_function_signatures();
py::class_<LLMNode...
...
options.enable_function_signatures();

Which worked-around the sphinx issue, but LLMNode::add_node no longer appears in the sub file, causing erroneous syntax errors in the IDEs that support parsing pyi files.

Minimum reproducible example

No response

Relevant log output

Click here to see error details

[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Nov 1, 2023
@dagardner-nv dagardner-nv added this to the 23.11 - Sherlock milestone Nov 1, 2023
@dagardner-nv dagardner-nv self-assigned this Nov 1, 2023
@dagardner-nv dagardner-nv moved this from Todo to Review - Ready for Review in Morpheus Boards Nov 1, 2023
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant