Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: C++ impl for DeserializeStage should support ControlMessage output #1328

Closed
2 tasks done
dagardner-nv opened this issue Oct 31, 2023 · 0 comments · Fixed by #1478
Closed
2 tasks done

[FEA]: C++ impl for DeserializeStage should support ControlMessage output #1328

dagardner-nv opened this issue Oct 31, 2023 · 0 comments · Fixed by #1478
Assignees
@dagardner-nv
Labels
feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components
Milestone
24.03 - Sherlock ...

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Critical (currently preventing usage)

Please provide a clear description of problem this feature solves

Currently only the Python impl supports this feature, however this creates a problem as ControlMessage only has a C++ impl which is counter-intuitive.

Describe your ideal solution

C++ impl for the DeserializeStage should support ControlMessage

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components labels Oct 31, 2023
@dagardner-nv dagardner-nv added this to the 23.11 - Sherlock milestone Oct 31, 2023
@dagardner-nv dagardner-nv self-assigned this Jan 24, 2024
@dagardner-nv dagardner-nv moved this from Todo to In Progress in Morpheus Boards Jan 24, 2024
@dagardner-nv dagardner-nv mentioned this issue Jan 24, 2024
Merged
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Jan 26, 2024
@jarmak-nv jarmak-nv moved this from Review - Ready for Review to In Progress in Morpheus Boards Jan 26, 2024
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Jan 26, 2024
@jarmak-nv jarmak-nv moved this from Review - Ready for Review to In Progress in Morpheus Boards Jan 26, 2024
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Jan 26, 2024
@rapids-bot rapids-bot bot closed this as completed in 77cc0e5 Feb 12, 2024
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Status: Done
Milestone
24.03 - Sherlock Improvements
Development

Successfully merging a pull request may close this issue.

Support ControlMessage output in the C++ impl of DeserializeStage dagardner-nv/Morpheus
2 participants
@mdemoret-nv @dagardner-nv