Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation and tests for the RetrieverNode #1301

Closed
4 tasks
Tracked by #1306
mdemoret-nv opened this issue Oct 22, 2023 · 1 comment
Closed
4 tasks
Tracked by #1306

Add documentation and tests for the RetrieverNode #1301

mdemoret-nv opened this issue Oct 22, 2023 · 1 comment
Assignees
@bsuryadevara
Labels
sherlock Issues/PRs related to Sherlock workflows and components
Milestone
23.11 - Sherlock

Comments

@mdemoret-nv
Copy link
Contributor

As part of Sherlock, a prototype of the RetrieverNode was created. This class will need the following improvements before being merged back to branch-23.11:

Tasks
Preview Give feedback

You can find the prototype located here

Note: the location above links directly to a commit with the prototype. The current location and functionality of the class may have changed.
@mdemoret-nv mdemoret-nv added the sherlock Issues/PRs related to Sherlock workflows and components label Oct 22, 2023
@mdemoret-nv mdemoret-nv added this to the 23.11 - Sherlock milestone Oct 22, 2023
@mdemoret-nv mdemoret-nv mentioned this issue Oct 22, 2023
Closed
27 tasks
@bsuryadevara bsuryadevara mentioned this issue Nov 6, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Nov 6, 2023
@bsuryadevara
RetrieverNode Tests and Docs (#1340)
05cd16b 
Closes #1301 

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Bhargav Suryadevara (https://github.com/bsuryadevara)

Approvers:
  - Devin Robison (https://github.com/drobison00)

URL: #1340
@mdemoret-nv
Copy link
Contributor Author

Linked PR did not close. Closing.

@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsuryadevara bsuryadevara

Labels
sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Status: Done
Milestone
23.11 - Sherlock
Development

No branches or pull requests
3 participants
@bsuryadevara @mdemoret-nv @dagardner-nv