Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Document and Test the LLMContext class #1297

Closed
2 tasks done
mdemoret-nv opened this issue Oct 20, 2023 · 1 comment
Closed
2 tasks done

[FEA]: Document and Test the LLMContext class #1297

mdemoret-nv opened this issue Oct 20, 2023 · 1 comment
Assignees
@efajardo-nv
Labels
feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components
Milestone
23.11 - Sherlock

Comments

@mdemoret-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

The LLMContext class is current in a prototype phase here: https://github.com/nv-morpheus/Morpheus/blob/bedca92ba09d88c46e5cb41eb41f172b8532c70b/morpheus/_lib/src/llm/llm_context.cpp

It needs to be documented and have comprehensive tests added to ensure all code paths are verified.

Describe your ideal solution

Add documentation for all public methods and a test for all code paths in C++ and any unique code paths in C++.

We will want to support creating LLMContext objects on both C++ and python without any Task or ControlMessage objects on it. So tests should include operating with null values for both of these options.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@mdemoret-nv mdemoret-nv added feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components labels Oct 20, 2023
@mdemoret-nv mdemoret-nv added this to the 23.11 - Sherlock milestone Oct 20, 2023
@efajardo-nv efajardo-nv mentioned this issue Oct 26, 2023
Merged
rapids-bot bot pushed a commit that referenced this issue Nov 9, 2023
@efajardo-nv
LLMContext C++ unit tests and docs (#1316)
324dde6 
Closes #1297

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)

Approvers:
  - Christopher Harris (https://github.com/cwharris)

URL: #1316
@efajardo-nv
Copy link
Contributor

Closed by PR #1316

@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efajardo-nv efajardo-nv

Labels
feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Status: Done
Milestone
23.11 - Sherlock
Development

No branches or pull requests
2 participants
@mdemoret-nv @efajardo-nv