Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Add tests for CoroutineRunnable MRC node type #1270

Closed
2 tasks done
mdemoret-nv opened this issue Oct 16, 2023 · 1 comment
Closed
2 tasks done

[FEA]: Add tests for CoroutineRunnable MRC node type #1270

mdemoret-nv opened this issue Oct 16, 2023 · 1 comment
Assignees
Labels
feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components

Comments

@mdemoret-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

For the fea-sherlock feature branch, a new class CoroutineRunnable has been added. It needs tests to ensure its functioning properly. This class is different from the existing PythonNode classes which use fibers as this node type uses coroutines.

Describe your ideal solution

Add tests that exercise edge cases when using this stage. Test scenarios should include:

  1. Exception handling from C++
  2. Exception handling from Python
  3. Cancelling python coroutines
  4. Cancelling python coroutines from C++

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@mdemoret-nv mdemoret-nv added the feature request New feature or request label Oct 16, 2023
@mdemoret-nv mdemoret-nv added this to the 23.11 - Sherlock milestone Oct 16, 2023
@mdemoret-nv mdemoret-nv added the sherlock Issues/PRs related to Sherlock workflows and components label Oct 16, 2023
@mdemoret-nv
Copy link
Contributor Author

Closing. This was migrated to MRC but it is complete

@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request sherlock Issues/PRs related to Sherlock workflows and components
Projects
Status: Done
Development

No branches or pull requests

2 participants