Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Wrong outputs from PreprocessFILStage #1250

Closed
2 tasks done
efajardo-nv opened this issue Oct 6, 2023 · 1 comment
Closed
2 tasks done

[BUG]: Wrong outputs from PreprocessFILStage #1250

efajardo-nv opened this issue Oct 6, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@efajardo-nv
Copy link
Contributor

Version

23.11

Which installation method(s) does this occur on?

Docker

Describe the bug.

In the process of migrating our 22.11 pipeline to 23.07, we noticed that results are now different. Upon investigating we found the source of the discrepancy was the output the PreprocessFILStage, both the C++ and Python versions. We noticed in 22.11, the cpp PreprocessFILStage creates a c_contiguous array, while the python version creates a f_continguous array. This can be resolved in the 23.07 Python version (preprocess_fil_stage.py) by changing:

data = cp.asarray([df.to](http://df.to/)_cupy()) 

to

data = cp.ascontiguousarray([df.to_cupy()).

Issue still exists when running pipeline in 23.11.

Minimum reproducible example

No response

Relevant log output

No response

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@efajardo-nv efajardo-nv added the bug Something isn't working label Oct 6, 2023
@efajardo-nv efajardo-nv self-assigned this Dec 11, 2023
@mdemoret-nv
Copy link
Contributor

Fixed by #1390

@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants