Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Fix Control Message Utils #1235

Closed
2 tasks done
bsuryadevara opened this issue Oct 3, 2023 · 0 comments · Fixed by #1243
Closed
2 tasks done

[BUG]: Fix Control Message Utils #1235

bsuryadevara opened this issue Oct 3, 2023 · 0 comments · Fixed by #1243
Assignees
@bsuryadevara
Labels
bug Something isn't working non-breaking Non-breaking change

Comments

@bsuryadevara
Copy link
Contributor

Version

23.11

Which installation method(s) does this occur on?

Docker

Describe the bug.

@cm_default_failure_context_manager(raise_on_failure=raise_on_failure) is applied to a function with raise_on_failure set to False, it currently raises the following error. The expected behavior is that it should gracefully suppress the error and proceed with the next batch of data.

Minimum reproducible example

No response

Relevant log output

E20230928 19:18:24.725535   183 context.cpp:124] /main/mrc::pymrc::PythonSegmentModule::write_to_smtp/internal_node; rank: 0; size: 1; tid: 140491307861568: set_exception issued; issuing kill to current runnable. Exception msg: UnboundLocalError: local variable 'ret_cm' referenced before assignment

At:
  /opt/conda/envs/morpheus/lib/python3.10/site-packages/morpheus/utils/control_message_utils.py(92): wrapper
  /opt/conda/envs/morpheus/lib/python3.10/site-packages/morpheus/utils/control_message_utils.py(44): wrapper

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@bsuryadevara bsuryadevara added bug Something isn't working non-breaking Non-breaking change labels Oct 3, 2023
@bsuryadevara bsuryadevara self-assigned this Oct 3, 2023
@bsuryadevara bsuryadevara mentioned this issue Oct 3, 2023
Closed
@bsuryadevara bsuryadevara linked a pull request Oct 3, 2023 that will close this issue
SQL Max Connection Exhaustion and Update Control Message Utils #1238
Closed
@bsuryadevara bsuryadevara mentioned this issue Oct 4, 2023
Merged
@bsuryadevara bsuryadevara linked a pull request Oct 4, 2023 that will close this issue
[BUG] Fix Control Message Utils & SQL Max Connections Exhaust #1243
Merged
rapids-bot bot pushed a commit that referenced this issue Oct 5, 2023
@bsuryadevara
[BUG] Fix Control Message Utils & SQL Max Connections Exhaust (#1243)
1b6e9f2 
- Updated SQL loader to utilize connections from the pool.
- Fixed control message utility variable referenced before assignment error.
closes #1237 #1235

Authors:
  - Bhargav Suryadevara (https://github.com/bsuryadevara)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1243
@bsuryadevara bsuryadevara moved this from Todo to Review - Approved in Morpheus Boards Oct 20, 2023
@github-project-automation github-project-automation bot moved this from Review - Approved to Done in Morpheus Boards Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsuryadevara bsuryadevara

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
1 participant
@bsuryadevara