Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: Expose manual_seed as an environment variable and/or CLI argument #1211

Closed
2 tasks done
dagardner-nv opened this issue Sep 21, 2023 · 0 comments · Fixed by #1445
Closed
2 tasks done

[FEA]: Expose manual_seed as an environment variable and/or CLI argument #1211

dagardner-nv opened this issue Sep 21, 2023 · 0 comments · Fixed by #1445
Assignees
@dagardner-nv
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Low (would be nice)

Please provide a clear description of problem this feature solves

It would be nice, when testing examples to be able to set manual_seed without modifying code.

Describe your ideal solution

Ideally both an environment variable and a CLI flag would be exposed.
The environment variable would allow someone to copy/paste example commands from README.md files without change.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Sep 21, 2023
@dagardner-nv dagardner-nv self-assigned this Sep 21, 2023
@dagardner-nv dagardner-nv mentioned this issue Dec 19, 2023
Merged
@jarmak-nv jarmak-nv moved this from Todo to Review - Ready for Review in Morpheus Boards Dec 19, 2023
rapids-bot bot pushed a commit that referenced this issue Dec 20, 2023
@dagardner-nv
Add a --manual_seed flag to the CLI (#1445)
0bd9e48 
* Allows manually seeding random number generators from the CLI via either `--manual_seed` or setting the `MORPHEUS_MANUAL_SEED` environment variable.
* Makes testing example CLI pipelines easier.

Closes #1211

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1445
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a --manual_seed flag to the CLI dagardner-nv/Morpheus
1 participant
@dagardner-nv