Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add map_async and flat_map_async Operators for Python Async Generators #392

Open
wants to merge 24 commits into
base: branch-23.11
Choose a base branch
from
Open

Add map_async and flat_map_async Operators for Python Async Generators #392

wants to merge 24 commits into from

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Sep 20, 2023 •
edited
Loading

Description

Adds new operators map_async and flat_map_async that can handle Python Async Generators concurrently.

Closes #386

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 20, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cwharris cwharris changed the title Add flatmap_async Operator for Python Async Generators Add flatmap_async Operator for Python Async Generators Sep 20, 2023
@cwharris cwharris changed the title Add flatmap_async Operator for Python Async Generators Add concat_map_async Operator for Python Async Generators Sep 22, 2023
@cwharris cwharris changed the title Add concat_map_async Operator for Python Async Generators Add flat_map_async Operator for Python Async Generators Sep 26, 2023
@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Sep 26, 2023
@cwharris cwharris marked this pull request as ready for review September 26, 2023 14:18
@cwharris cwharris requested review from a team as code owners September 26, 2023 14:18
@cwharris
Copy link
Contributor Author

/ok to test

@cwharris
Copy link
Contributor Author

/ok to test

@cwharris
Copy link
Contributor Author

/ok to test

@cwharris cwharris changed the title Add flat_map_async Operator for Python Async Generators Add map_async and flat_map_async Operators for Python Async Generators Sep 26, 2023
@cwharris
Copy link
Contributor Author

/ok to test

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 87.02703% with 24 lines in your changes missing coverage. Please review.

Project coverage is 73.78%. Comparing base (8b20469) to head (e072c63).
Report is 9 commits behind head on branch-23.11.

Files with missing lines Patch % Lines
python/mrc/_pymrc/src/operators.cpp 82.24% 19 Missing ⚠️
cpp/mrc/src/public/runnable/context.cpp 87.50% 2 Missing ⚠️
...pp/mrc/include/mrc/runnable/detail/type_traits.hpp 0.00% 1 Missing ⚠️
python/mrc/_pymrc/src/node.cpp 97.43% 1 Missing ⚠️
python/mrc/_pymrc/src/segment.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #392      +/-   ##
================================================
+ Coverage         73.59%   73.78%   +0.19%     
================================================
  Files               385      387       +2     
  Lines             13614    13780     +166     
  Branches           1028     1040      +12     
================================================
+ Hits              10019    10168     +149     
- Misses             3595     3612      +17
Flag Coverage Δ
cpp 68.86% <12.02%> (-0.81%) ⬇️
py 42.80% <87.22%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cpp/mrc/include/mrc/runnable/context.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/runnable/engine.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/runnable/launch_control.hpp 83.33% <100.00%> (+1.70%) ⬆️
cpp/mrc/include/mrc/runnable/runner.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/segment/builder.hpp 80.00% <100.00%> (+0.37%) ⬆️
cpp/mrc/include/mrc/segment/context.hpp 85.71% <100.00%> (ø)
cpp/mrc/src/internal/runnable/engine.cpp 100.00% <ø> (+16.66%) ⬆️
cpp/mrc/src/public/runnable/runner.cpp 78.21% <100.00%> (ø)
python/mrc/_pymrc/include/pymrc/node.hpp 61.22% <ø> (ø)
python/mrc/_pymrc/include/pymrc/operators.hpp 100.00% <100.00%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b20469...e072c63. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cwharris cwharris

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Review - Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Support for Async Operators
1 participant
@cwharris