Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs.writeable has changed to fs.writable as of node v0.3.5 #8

Open
jtsao22 opened this issue Aug 11, 2011 · 0 comments
Open

fs.writeable has changed to fs.writable as of node v0.3.5 #8

jtsao22 opened this issue Aug 11, 2011 · 0 comments

Comments

@jtsao22
Copy link

jtsao22 commented Aug 11, 2011

Hey Dallin,

I just wanted to let you know that in node v0.3.5 and later the streams now use the stream.writable boolean instead of the stream.writeable boolean (http://nodejs.org/docs/v0.3.5/api/streams.html#stream.writable).

Thus in s3.js @ line 308:

    if(!fileStream.writeable){

should be changed to:

    if(!fileStream.writable){

This should not be changed on versions of node before v0.3.5, so maybe there's a better way? Perhaps there's a way to check for the node version?

Thanks for the module btw.

Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant