From 2d5e4727ae8aa75f90d38bf94e0e18596fc1d0b8 Mon Sep 17 00:00:00 2001 From: Valentin Oliver Loftsson Date: Wed, 1 Sep 2021 09:15:55 +0200 Subject: [PATCH] fix(meta,manifest): set default undefined for description and author --- docs/content/en/manifest.md | 2 +- docs/content/en/meta.md | 4 ++-- src/manifest.ts | 2 +- src/meta.ts | 4 ++-- types/manifest.d.ts | 2 +- types/meta.d.ts | 4 ++-- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/content/en/manifest.md b/docs/content/en/manifest.md index 1ce4509c..03f01ee9 100644 --- a/docs/content/en/manifest.md +++ b/docs/content/en/manifest.md @@ -27,7 +27,7 @@ pwa: { | --------------------------------- | --------------- | ------------------------------------------------------------ | --------------------------------------------------------------- | | `name` \*1 | `String` | `package.json`'s name property | [maximum of 45 characters] | | `short_name` \*1 | `String` | `package.json`'s name property | [maximum of 12 characters] | -| `description` \*2 | `String` | `package.json`'s description property | | +| `description` \*2 | `String` | `undefined` | | | `icons` \*1 | `Array` | `[]` | (See the [icon module]) | | `start_url` \*1 | `String` | `routerBase + '?standalone=true'` | It has to be relative to where the manifest is placed | | `display` \*1 | `String` | `'standalone'` | | diff --git a/docs/content/en/meta.md b/docs/content/en/meta.md index 41a2c3d4..2dd5ddff 100644 --- a/docs/content/en/meta.md +++ b/docs/content/en/meta.md @@ -67,11 +67,11 @@ These articles will help you decide an appropriate value: - Meta: `title` ### `author` -- Default: *npm_package_author_name* +- Default: `undefined` - Meta: `author` ### `description` -- Default: *npm_package_description* +- Default: `undefined` - Meta: `description` ### `theme_color` diff --git a/src/manifest.ts b/src/manifest.ts index 20c0864f..c8f277c4 100755 --- a/src/manifest.ts +++ b/src/manifest.ts @@ -9,7 +9,7 @@ export function manifest (nuxt, pwa: PWAContext) { const defaults: ManifestOptions = { name: process.env.npm_package_name, short_name: process.env.npm_package_name, - description: process.env.npm_package_description, + description: undefined, publicPath, icons: [], start_url: routerBase + '?standalone=true', diff --git a/src/meta.ts b/src/meta.ts index c876e1f7..3ce83f6d 100755 --- a/src/meta.ts +++ b/src/meta.ts @@ -8,8 +8,8 @@ export function meta (nuxt, pwa: PWAContext, moduleContainer) { // Defaults const defaults: MetaOptions = { name: process.env.npm_package_name, - author: process.env.npm_package_author_name, - description: process.env.npm_package_description, + author: undefined, + description: undefined, charset: 'utf-8', viewport: undefined, mobileApp: true, diff --git a/types/manifest.d.ts b/types/manifest.d.ts index 8787cb0f..4f725b89 100644 --- a/types/manifest.d.ts +++ b/types/manifest.d.ts @@ -10,7 +10,7 @@ export interface ManifestOptions { */ short_name: string, /** - * Default: _npm_package_description_ + * Default: undefined */ description: string, /** diff --git a/types/meta.d.ts b/types/meta.d.ts index 16f5f0d5..b98dd51b 100644 --- a/types/meta.d.ts +++ b/types/meta.d.ts @@ -52,13 +52,13 @@ export interface MetaOptions extends Partial { */ title?: string, /** - * Default: _npm_package_author_name_ + * Default: undefined * * Meta: `author` */ author: string, /** - * Default: _npm_package_description_ + * Default: undefined * * Meta: `description` */