Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imprv] add functionality configure timeout value to module any module, for example vms.py #409

Open
ArtemProt opened this issue Oct 4, 2023 · 1 comment · May be fixed by #436
Open
Assignees
Labels
1.9.3_triage Bug fixes & Improvements enhancement New feature or request

Comments

@ArtemProt
Copy link

Describe the request

Add functionality in modules to override default timeout value for API calls.

Current behaviour

There is module vms.py:

https://github.com/nutanix/nutanix.ansible/blob/main/plugins/module_utils/prism/vms.py

It has hardcode value for time in API calls:

def list( self, data=None, endpoint=None, use_base_url=False, raise_error=True, no_response=False, timeout=30, max_length=500,

In some cases we can see inventory failed and on IKAT of PC it shows ansible-httpget as disconnected after exactly 30 sec.
We have tried to change timeout value in ansible settings, but it failed again with exact same timeout 30 secs.

Expected behaviour

Modules should or take ansible-httpget timeout value
https://docs.ansible.com/ansible/latest/collections/ansible/builtin/uri_module.html

Or we should allow to change it in any other manner.

@ArtemProt ArtemProt added the enhancement New feature or request label Oct 4, 2023
@bhati-pradeep bhati-pradeep added the 1.9.1 Bug fixes & Improvements label Oct 12, 2023
@bhati-pradeep bhati-pradeep added 1.9.3_triage Bug fixes & Improvements and removed 1.9.1 Bug fixes & Improvements labels Nov 9, 2023
@bhati-pradeep
Copy link
Collaborator

There was a some misunderstanding regarding the fix in project dashboard and release 1.9.1 doesn't contains fix. Moving it to 1.9.2

@Gevorg-Khachatryan-97 Can you please raise PR and share. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.9.3_triage Bug fixes & Improvements enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

6 participants