Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify resources request and limits in Deployments and DeamonSet #138

Open
murand78 opened this issue Jan 30, 2024 · 3 comments

Comments

@murand78
Copy link

Currently

https://github.com/nutanix/helm/blob/master/charts/nutanix-csi-storage/templates/ntnx-csi-node-ds.yaml
https://github.com/nutanix/helm/blob/master/charts/nutanix-csi-storage/templates/ntnx-csi-controller-deployment.yaml

have a QoS Guaranteed with fixed resource request.
In small dev clusters I notice that 0.5 CPU and 800MB of RAM are reserved, while only 0.0005 CPU and 200MB are used.

Can be possible to parametrize resources based on helm values?

Eg, replacing in templates:

      {{- with .Values.controller.resources }}
      resources:
        {{- toYaml . | nindent 12 }}
      {{- end }}

instead of :

      resources:
        requests:
          cpu: 100m
          memory: 200Mi
@tuxtof
Copy link
Collaborator

tuxtof commented Feb 7, 2024

we plan to integrate it in next CSI 3.0 release
did you expect to have it only for main controller or also for sidecards ?

@murand78
Copy link
Author

murand78 commented Feb 7, 2024

Could be nice to have all resources configurable.

@tuxtof
Copy link
Collaborator

tuxtof commented Feb 7, 2024

ok noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants