Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent exception to same kind of exception #1313

Open
nus-pe-bot opened this issue Apr 16, 2022 · 1 comment
Open

Inconsistent exception to same kind of exception #1313

nus-pe-bot opened this issue Apr 16, 2022 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 16, 2022

Screen Shot 2022-04-16 at 4.39.55 PM.png
The same kind of invalid input(route of index not exists), but getting different exception message. The second exception message should be undefined behavior.
Moreover, there is actually a bound of number of routes in the app, which is 2147483647, because the previous inconsistent exception message reflects that the data type used to storing the number of routes is an "int", which has naturally bound 2147483647. Without declaration, the records will be overwritten when the number of routes exceeds 2147483647.


[original: nus-cs2113-AY2122S2/pe-interim#1311] [original labels: severity.Medium type.FunctionalityBug]
@suenalaba
Copy link
Contributor

suenalaba commented Apr 19, 2022

Team's Response

Thank you for reporting it.

This problem of integer overflow can only happen in case of deliberate sabotage. The app does not crash and the input is not accepted. Thus the data will not be corrupted. Therefore, we think that it is more reasonable to be a low severity bug.

This is consistent with the specification on module website:

image.png

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants