[Hue Koh] iP #456

huekoh · 2024-02-05T09:57:11Z

GMO (GameMate Organizer) 👾 🚀

"Who wants to play video games?" - GMO

GMO's not a bad influence... he

helps you remember your tasks
~~SULKS~~ reminds you when you are slaved by work
tells you to hurry so you can play with him!

All you need to do is

Download GMO here
Double click it
Start telling GMO your dues
Let him keep track of them for you 🤩

And he is FREE

GMO's Features:

Keep track of tasks (todos, dues, events)
Manage task status
Sort tasks by date
Tell you to skip lecture

And if you are a Java programmer, use him to practice your coding too! Here's GMO's constructor method:

public GMO() {
        ui = new Ui();
        storage = new Storage();

        try {
            tasks = new TaskList(storage.loadData(), ui, storage);
        } catch (IOException e) {
            System.out.println("Error: Unable to load data. " + e.getMessage());
            tasks = new TaskList(ui);
        }
    }

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

BMO now echoes back everything you say to him

abstracted tasks into a separate class

Error handling now handles these: 1. general error 2. index provided is out of range 3. task to be done is already done 4. task to be redone is already not done 5. no index was provided 6. user input add with nothing following up 7. incorrect deadline input format 8. incorrect todo input format 9. incorrect event input format

The formatter now recognises date time strings with "/" to express dates as valid. Previously, strings containing "/" would throw a format error and not accept it as a valid string

When user adds a task with a date time variable, the string will be formatted into a LocalDateTime object that is stored in the task object.

nichee

All good! Just small naming issues here and there

nichee · 2024-02-06T10:50:46Z

src/main/java/BMO.java

+    static void viewLog() {
+        StringBuilder logPrint = new StringBuilder();
+        if (taskLog.isEmpty()) {
+            System.out.println(Constants.emptyLogPrint);


Consider renaming this function to "printEmptyLog" to start the name with the verb

nichee · 2024-02-06T10:52:09Z

src/main/java/BMO.java

+        int index = Integer.parseInt((input));
+
+        if (index > taskLog.size() || index <= 0) {
+            System.out.println(Constants.errorPrint.outOfRange());


Consider changing the naming convention of the printing functions like outOfRange, perhaps use a verb?

nichee · 2024-02-06T10:55:20Z

src/main/java/ToDos.java

@@ -0,0 +1,11 @@
+public class ToDos extends Task {


As far as I can tell this is the Todo class and not multiple Todos? Perhaps this can be changed to Todo since its used to instantiate single instances, so "ToDos" so it may be confusing

qinboan

LGTM, just a few nits to fix!

qinboan · 2024-02-12T17:47:07Z

src/main/java/BMO.java

+import java.util.*;
+import java.lang.*;


Avoid using wildcard imports as per java coding standard!

qinboan · 2024-02-12T17:48:12Z

src/main/java/BMO.java

+            String taskDescription = info[2].trim();
+
+            switch (taskType) {
+                case "T":


There should be no indentation for case clauses

qinboan · 2024-02-12T17:51:30Z

src/main/java/Task.java

+        return (isDone ? "[X]" : "[ ]"); // mark done task with X
+    }
+
+    public Boolean getStatus() {


Consider renaming this boolean method to sound like booleans.

Suggested change

public Boolean getStatus() {

public Boolean isDone() {

qinboan · 2024-02-12T17:54:57Z

src/main/java/TaskManager.java

+        return taskLog;
+    }
+
+    // Other methods for task management...


Maybe you should delete this comment as it serves no purpose :)

HusseinSafwan02

Just some minor fixes, well done!

HusseinSafwan02 · 2024-02-13T04:39:02Z

src/main/java/Constants.java

+            + "    Let's play mario kart right now!!\n"
+            + "----------------------------------------------------------------------------------\n";
+
+    public static class errorPrint {


maybe you can consider renaming the class to errorPrints, since it has multiple error messages

HusseinSafwan02 · 2024-02-13T04:44:35Z

src/main/java/TaskManager.java

+    }
+
+    private boolean isValidContentFormat(String content) {
+        // Implement your logic to check whether the content format is valid


I'm not very sure of the purpose of the comment here

HusseinSafwan02 · 2024-02-13T04:46:49Z

src/main/java/BMO.java

+
+    static void parseData(String content) {
+        String[] lines = content.split("\n");
+        Integer indexCounter = 0;


you can use int here else there is unnecessary unboxing

A more oop

This reverts commit 16a7afd, reversing changes made to b3a931f.

This reverts commit 5f73efc, reversing changes made to e5370f5.

Add assertions to the BMO, Storage and TaskList classes Several methods in these classes require important assumptions to hold true in order for the program to run. Assertions for these conditions to the code helps the debugging process. Let's add assertions to these classes.

Parse parse method is too long and handles both input type checking and input format checking. Having smaller methods to handle the different types of possible inputs makes the code more readable. Let's update the parser method to handle only input type checking, and abstract out input format checking to appropriate methods.

Add assertions to Deadlines and Events classes

Parse parse method is too long and handles both input type checking and input format checking. Having smaller methods to handle the different types of possible inputs makes the code more readable. Let's update the parser method to handle only input type checking, and abstract out input format checking to appropriate methods.

TaskList constructor method is too long and has duplicated code. Swapping around the try block to encapsulate the switch block instead of vice versa helps remove duplicate code and improve readability. Let's update the TaskList constructor method and reduce duplicate codes

A-assertions

A-code quality

damithc and others added 13 commits January 7, 2024 18:33

docs/README.md: Tweak document template

55f9f9f

Let's tweak the docs/README.md (which is used as the user guide) to fit Duke better. Specifically, 1. mention product name in the title 2. mention adding a product screenshot and a product intro 3. tweak the flow to describe feature-by-feature

Add Gradle support

f837ddb

Bump gradle and lib version

a6f7324

Created BMO.java, my own chatbot

61a827b

Updated BMO.java

af6c7c5

BMO now echoes back everything you say to him

Implemented list adder

c856ca2

implemented checklog array

79772ec

created Task.java

bb1c6e8

abstracted tasks into a separate class

Created more .java files

2b558e2

created subclasses of task

67c24ef

Implemented text ui testing

8a5a225

added task deletion option

ed1370c

huekoh changed the title ~~[Hue Koh] i~~ [Hue Koh] iP Feb 5, 2024

huekoh added 4 commits February 5, 2024 21:39

Added save and load of tasks data

aea83d7

Update BMO.java addLog function

492ccfc

The formatter now recognises date time strings with "/" to express dates as valid. Previously, strings containing "/" would throw a format error and not accept it as a valid string

Create BMO.java formatDateTime function

383e95f

When user adds a task with a date time variable, the string will be formatted into a LocalDateTime object that is stored in the task object.

Merge branch 'branch-level-8'

b3a931f

nichee reviewed Feb 6, 2024

View reviewed changes

qinboan reviewed Feb 12, 2024

View reviewed changes

Abstract data manager out

66fdcbd

HusseinSafwan02 reviewed Feb 13, 2024

View reviewed changes

huekoh and others added 8 commits February 15, 2024 00:30

Abstracted out UI, Parser, TaskList, Commands, and Storage

ae27309

Troubleshooting

37145eb

Ensured errors don't crash terminal

6a53c79

Merge pull request #1 from huekoh/A-MoreOOP

16a7afd

A more oop

Revert "Merge pull request #1 from huekoh/A-MoreOOP"

e5370f5

This reverts commit 16a7afd, reversing changes made to b3a931f.

Removed redundant imports

08a57ae

Merge branch 'A-MoreOOP'

5f73efc

Revert "Merge branch 'A-MoreOOP'"

2378bb2

This reverts commit 5f73efc, reversing changes made to e5370f5.

huekoh and others added 30 commits February 19, 2024 00:20

Merge branch 'Level-9'

fedd628

Implemented Checkstyle

3b5c008

Fixed code to adhere to checkstyle test

184bcbf

Updated GUI up to JavaFX tutorial 2

a5cb836

Updated GUI to have user interaction

09a4de3

Updated GUI code to use FXML, still buggy

d4d44c7

Updated all UI.class methods to return a String

df48379

Updated execute() of command to return a string for response

0a61b24

Removed separation lines from UI

484327e

Removed unused methods from BMO.java

c378142

Add assertions

f52e71c

Add assertions to Deadlines and Events classes

Merge pull request #3 from huekoh/A-Assertions

2788eba

A-assertions

Merge branch 'master' into A-CodeQuality

12cc784

Merge pull request #4 from huekoh/A-CodeQuality

3aba4a8

A-code quality

Add Ui.png

aaf84da

Add compareTo methods for task classes

6f8118f

Add sort command to sort task log

74a3e1a

Update Ui.java with new method printSortEmptyLog()

fd441b7

Update README.md

683bdcc

Rebrand BMO to GMO

025a761

Credit code reuses

868d500

Update Gmo.java javadocs

837c9b0

Update README.md

d030bc5

Fix checkstyle violations

05d97c0

Update assets

b5424dd

Update README.md with Ui.png

d63d186

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hue Koh] iP #456

[Hue Koh] iP #456

huekoh commented Feb 5, 2024 •

edited

Loading

nichee left a comment

nichee Feb 6, 2024

nichee Feb 6, 2024

nichee Feb 6, 2024

qinboan left a comment

qinboan Feb 12, 2024

qinboan Feb 12, 2024

qinboan Feb 12, 2024

qinboan Feb 12, 2024

HusseinSafwan02 left a comment

HusseinSafwan02 Feb 13, 2024

HusseinSafwan02 Feb 13, 2024

HusseinSafwan02 Feb 13, 2024

		import java.util.*;
		import java.lang.*;

[Hue Koh] iP #456

Are you sure you want to change the base?

[Hue Koh] iP #456

Conversation

huekoh commented Feb 5, 2024 • edited Loading

GMO (GameMate Organizer) 👾 🚀

nichee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qinboan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HusseinSafwan02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huekoh commented Feb 5, 2024 •

edited

Loading