Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandResult not Destroyed #3149

Open
nus-pe-bot opened this issue Apr 16, 2021 · 1 comment
Open

CommandResult not Destroyed #3149

nus-pe-bot opened this issue Apr 16, 2021 · 1 comment
Assignees
@glatiuden
Labels
response.Rejected severity.VeryLow status.Done team.3 tutorial.CS2103-T14 type.DocumentationBug

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 16, 2021 •
edited by glatiuden
Loading

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


CommandResult should be destroyed after returning

image.png

[original: nus-cs2103-AY2021S2/pe-interim#3149] [original labels: severity.Low type.DocumentationBug]
@glatiuden
Copy link
Contributor

glatiuden commented Apr 17, 2021 •
edited
Loading

Team's Response

Dear responder, thank you for highlighting this bug. We have actually took reference from the AB3's Sequence Diagram and we don't see ComandResult being destroyed as well.

image.png

Duplicate status (if any):

--

@glatiuden glatiuden self-assigned this Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glatiuden glatiuden

Labels
response.Rejected severity.VeryLow status.Done team.3 tutorial.CS2103-T14 type.DocumentationBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glatiuden @nus-pe-bot