Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input of Time Into Address Accepted for Filters #3145

Open
nus-pe-bot opened this issue Apr 16, 2021 · 1 comment
Open

Input of Time Into Address Accepted for Filters #3145

nus-pe-bot opened this issue Apr 16, 2021 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 16, 2021

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



I accidentally inputed the time format for address filter and it still works. Marking only as low although it has major ramifications because this is probably a regex issue.

image.png


[original: nus-cs2103-AY2021S2/pe-interim#3145] [original labels: severity.Low type.FunctionalityBug]
@kingsleykuan
Copy link
Contributor

kingsleykuan commented Apr 17, 2021

Team's Response

Thank you for your report, however we believe it should be rejected as the address field accepts any string as input, including all numbers and symbols. Coincidentally, this means that even strings which resemble a date time are accepted.

Furthermore, as this bug was reported during the Part II (Evaluating Documents) stage, it has to be rejected as it is not related to quality of documentation.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants