Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update swig to 3.0.12 #1321

Merged
merged 4 commits into from
Jan 17, 2018
Merged

update swig to 3.0.12 #1321

merged 4 commits into from
Jan 17, 2018

Conversation

breznak
Copy link
Member

@breznak breznak commented May 24, 2017 •
edited
Loading

Fixes #1293

Replaces #1318

TODO:

  • fix swig for windows

@breznak breznak mentioned this pull request May 24, 2017
Open
@breznak
Copy link
Member Author

breznak commented Jan 10, 2018 •
edited
Loading

Windows is causing troubles:

[ 71%] Built target Swig
[ 71%] Swig source
(1) : Error: Unable to find 'swig.swg'
(3) : Error: Unable to find 'python.swg'

Here https://ci.appveyor.com/project/numenta-ci/nupic-core/build/0.3.0.2226/job/22yglo6elbtw1u80#L1358

And the solution can be found

Known Issues
============
There are minor known bugs, details of which are in the bug tracker, see
http://www.swig.org/bugs.html.

Troubleshooting
===============
In order to operate correctly, SWIG relies upon a set of library
files.  If after building SWIG, you get error messages like this,

    $ swig foo.i
    :1. Unable to find 'swig.swg'
    :3. Unable to find 'tcl8.swg'

it means that SWIG has either been incorrectly configured or
installed.  To fix this:

    1.  Make sure you remembered to do a 'make install' and that
        the installation actually worked.  Make sure you have
        write permission on the install directory.

    2.  If that doesn't work, type 'swig -swiglib' to find out
        where SWIG thinks its library is located.

    3.  If the location is not where you expect, perhaps
        you supplied a bad option to configure.  Use
        ./configure --prefix=pathname to set the SWIG install
        location.   Also, make sure you don't include a shell
        escape character such as ~ when you specify the path.

    4.  The SWIG library can be changed by setting the SWIG_LIB
        environment variable.  However, you really shouldn't
        have to do this.

If you are having other troubles, you might look at the SWIG Wiki at
https://github.com/swig/swig/wiki.

EDIT:
MinGW link https://aliowka.wordpress.com/2010/07/09/creating-python-extensions-in-cc-with-swig-on-mingw-gcc-under-windows/

breznak
breznak commented Jan 10, 2018
View reviewed changes
src/CMakeLists.txt Outdated
# https://github.com/numenta/nupic.core/pull/1321#issuecomment-356665619
-python
-I${SWIG_PATH}/Lib
-I${SWIG_PATH}/Lib/python
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit moves us from

#1321 (comment)
to
https://ci.appveyor.com/project/numenta-ci/nupic-core/build/0.3.0.2227/job/hcx4ji7p9s5pbg0i#L1357

@rhyolight do you know someone on Windows who can look into the swig paths? Where the new swig binary is located and what paths it expects

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@breznak I added windows support to your branch with this PR breznak#3
Here is the windows build log:

CC: @rhyolight

breznak
breznak commented Jan 10, 2018
View reviewed changes
Copy link
Member Author

@breznak breznak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing windows side of the new swig ... Help wanted

@rhyolight rhyolight requested a review from lscheinkman January 10, 2018 17:55
@lscheinkman lscheinkman self-assigned this Jan 16, 2018
@lscheinkman lscheinkman mentioned this pull request Jan 17, 2018
Merged
lscheinkman
lscheinkman requested changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@lscheinkman lscheinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see breznak#3

@breznak
Copy link
Member Author

breznak commented Jan 17, 2018 •
edited
Loading

Thank you @lscheinkman for the Win fix!
EDIT 2:
@rhyolight some "web-flow guy" is not passing the Contributor Validation check ...aand it's gone after the comment, nice 😉 still there

Contributor Validator — web-flow must sign the Contributor License

@rhyolight rhyolight merged commit 4a9c8a2 into numenta:master Jan 17, 2018
@breznak breznak deleted the update_swig branch January 17, 2018 22:09
@rhyolight rhyolight mentioned this pull request Mar 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lscheinkman lscheinkman lscheinkman approved these changes

Assignees

@lscheinkman lscheinkman

Labels
status:ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundled swig version is old
3 participants
@breznak @lscheinkman @rhyolight