Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Sidechain for previews #33

Open
thomaswilburn opened this issue Oct 11, 2019 · 1 comment
Open

Move to Sidechain for previews #33

thomaswilburn opened this issue Oct 11, 2019 · 1 comment

Comments

@thomaswilburn
Copy link
Contributor

We don't want to transition our live NPR embeds to Sidechain just yet--there are multiple issues to deal with. But it would be beneficial to have a limited domain in which we start to test it, and it would also make the multi-page development setup smoother (because Sidechain listens and reacts to changes for its src attribute. Let's look at using Sidechain just to host the preview for now, as a step toward eventually using it on child pages as well, and then eventually on NPR.org.

Issues to address:

  • I don't think we use the Pym Loader extra features, but we should be prepared to shim them.
  • The parent page doesn't currently use the JS bundler, so it doesn't have access to Node modules, and we would need that.
  • Debugging needs to be solid in a shadow root.
thomaswilburn pushed a commit that referenced this issue Aug 27, 2021
@thomaswilburn
Copy link
Contributor Author

This work is done in the sidechain-previews branch, just needs to be checked and merged in. @ruthwtalbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant