Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider merging lint in the general flow as an additional usecase #887

Open
ShiriMoran opened this issue Sep 23, 2024 · 3 comments
Open

Comments

@ShiriMoran
Copy link
Contributor

          Function name is confusing - lint doesn't really have use cases.

By the way, why isn't "lint" a separate use case?

Originally posted by @zivnevo in #875 (comment)

@ShiriMoran
Copy link
Contributor Author

Possible; we will have to add []linter to the OutputGenerator

@zivnevo zivnevo added this to the v0.8 milestone Sep 25, 2024
@ShiriMoran
Copy link
Contributor Author

Integrating lint in the general flow can be done only once #638 is solved.

  1. Lint strongly relies on vpcmodel structs
  2. The Output generator also resides in vpcmodel
  3. vpcmodel is kindda spaghetti
  4. Lint resides in a dedicated package, not vpcmodel
  5. Integrating as is will create a circular dependency
    Thus, we can integrate either by moving Lint into the vpcmodel or by separation of vpcmodel to distinct well defined packages with interfaces between them. The former solution is highly undesired, and thus we are left with the later one

(I did performs a few attempts of a quick and dirty separation of the vpcmodel that will enable the integration, and ended up with circular dependencies. Seems there are no short cuts here)

@zivnevo
Copy link
Member

zivnevo commented Oct 1, 2024

Related to #212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants