Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add toggle to randomize the seed after generating #39

Open
aaronsantiago opened this issue Sep 7, 2022 · 3 comments · May be fixed by #43
Open

[Feature Request] Add toggle to randomize the seed after generating #39

aaronsantiago opened this issue Sep 7, 2022 · 3 comments · May be fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@aaronsantiago
Copy link

aaronsantiago commented Sep 7, 2022

Doing multiple generations with the same prompt is problematic when using the same seed as it tends to "deep fry" the image. It would be significantly smoother if koi had a system for randomizing seeds.

I think the expected behavior for this toggle should be:

  • When you click "dream," if the toggle is on,
    • Read the current seed value and use that for generation
    • Replace the current seed value with a random seed
  • If the toggle is off, and you click it on,
    • Replace the current seed value with a random seed
  • If the toggle is on, and you edit the seed,
    • Turn the toggle off

This allows for manual intervention with seeds when desired, and maintains clarity as to which seed is being used while randomness is on.

@tocram1
Copy link
Contributor

tocram1 commented Sep 7, 2022

If the toggle is on, and you click it on

You mean that when the toggle is on and the user clicks on the text field for the seed input, it generates a new one ?

This whole behavior might actually not be that difficult to make, I might try to work on this issue ! Gotta get a grip of how Krita handles UI, but with what @nousr already has made, it shouldn't be that hard to implement ;)

@nousr
Copy link
Owner

nousr commented Sep 7, 2022

@tocram1 awesome! I'll assign this one to you--let me know if you get stuck or want me to take you off of it 👍

@nousr nousr added the enhancement New feature or request label Sep 7, 2022
@aaronsantiago
Copy link
Author

Oops! That was a typo, I meant to write:

  • If the toggle is off, and you click it on,
    • Replace the current seed value with a random seed

This was referenced Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants