Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Default Show Page (thumbnail only) #149

Closed
2 tasks
jillpe opened this issue Oct 8, 2024 · 1 comment
Closed
2 tasks

Theme: Default Show Page (thumbnail only) #149

jillpe opened this issue Oct 8, 2024 · 1 comment

Comments

@jillpe
Copy link

jillpe commented Oct 8, 2024

Summary

There are some discrepancies between the knapsack version and HykuCommons version of the default show page for a non-image (UV):

  • 'Add to collection', 'Feature', 'Analytics', 'Edit', 'Attach Child', 'Delete' buttons do not match HykuCommons styling
  • Items banner is not yellow like HykuCommons

Knapsack

Screen.Recording.2024-10-08.at.12.24.29.PM.mov

HykuCommons

Screen.Recording.2024-10-08.at.12.25.24.PM.mov

Acceptance Criteria

  • 'Add to collection', 'Feature', 'Analytics', 'Edit', 'Attach Child', 'Delete' buttons match HykuCommons styling
  • Items banner is yellow like HykuCommons
@jillpe jillpe converted this from a draft issue Oct 8, 2024
@jillpe jillpe changed the title Theme: Default Show Page Theme: Default Show Page (thumbnail only) Oct 8, 2024
@laritakr
Copy link
Contributor

laritakr commented Dec 2, 2024

Closing - should be handled in #177

@laritakr laritakr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
@github-project-automation github-project-automation bot moved this from Ready for Development to Done in PalsKnapsack Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants