i1026 Fix AdminSet-related 504 timeout errors on work forms #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work forms were throwing 504 time out errors because large AdminSets being queried by Hyrax#query_service were loading all of their members. This fix is a backport of this Hyrax commit: - samvera/hyrax@75312ee This override is no longer needed when Hyrax's version is >= v5.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Ref:
Work forms were throwing 504 time out errors because large AdminSets being queried by Hyrax#query_service were loading all of their members.
This fix is a backport of this Hyrax commit:
Expected Behavior Before Changes
New work forms throw 504 time out errors in the Grace tenant
Expected Behavior After Changes
New work forms no longer throw 504 time out errors in the Grace tenant
Notes
This override is no longer needed when Hyrax's version is >= v5.0.1