doc: update signature specification for v1 release #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Zha <[email protected]>
yizha1
requested review from
gokarnm,
justincormack,
NiazFK,
priteshbandi,
SteveLasker,
shizhMSFT,
toddysm and
vaninrao10
as code owners
iamsamirzon
reviewed
May 8, 2023
There was a problem hiding this comment.
@yizha1 - For this set of changes, I believe changing "Notary v2" to "Notary" is not the right decision. I will suggest replacing "Notary v2" to "Notary Project" will be more appropriate. I am basing it on - "https://cloud-native.slack.com/archives/CQUH8U287/p1678224360929939?thread_ts=1678194257.621559&cid=CQUH8U287" discussion
toddysm
requested changes
May 9, 2023
Signed-off-by: Yi Zha <[email protected]>
iamsamirzon
reviewed
May 10, 2023
iamsamirzon
reviewed
May 10, 2023
iamsamirzon
previously approved these changes
May 10, 2023
toddysm
requested changes
May 10, 2023
Signed-off-by: Yi Zha <[email protected]>
shizhMSFT
reviewed
May 19, 2023
toddysm
requested changes
May 20, 2023
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
|
@priteshbandi @toddysm could you re-review the spec again? The initial purpose of this PR is to remove the reference of |
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
Signed-off-by: Yi Zha <[email protected]>
|
@gokarnm @priteshbandi Would you mind reviewing this PR? |
15 tasks
toddysm
approved these changes
Aug 3, 2023
priteshbandi
reviewed
Aug 4, 2023
gokarnm
reviewed
Aug 5, 2023
gokarnm
reviewed
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #255
Signed-off-by: Yi Zha [email protected]