Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vote: tag 1.0.0 #15

Closed
4 of 6 tasks
priteshbandi opened this issue Jan 24, 2024 · 8 comments
Closed
4 of 6 tasks

vote: tag 1.0.0 #15

priteshbandi opened this issue Jan 24, 2024 · 8 comments
Labels
triage

Comments

@priteshbandi
Copy link
Contributor

priteshbandi commented Jan 24, 2024 •
edited by shizhMSFT
Loading

Release

This would mean tagging b708a08 as v1.0.0 to release.

Vote

We need at least 4 approvals from 6 maintainers to release notation-plugin-framework-go v1.0.0.

Changes

The code changes to include:

What's Changed

Full Changelog: e82d02b...b708a08

Action Requested

Please respond LGTM or REJECT(with reason).
@priteshbandi priteshbandi added bug Something isn't working triage and removed bug Something isn't working labels Jan 24, 2024
@JeyJeyGao
Copy link
Contributor

LGTM

1 similar comment
@Two-Hearts
Copy link
Contributor

LGTM

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Jan 30, 2024 •
edited
Loading

@priteshbandi I've made some improvements in #17. Could you take a look?

@priteshbandi
Copy link
Contributor Author

priteshbandi commented Jan 31, 2024 •
edited
Loading

I've updated the commit list and included two more PRs (#17, #16).

Please re-vote

@shizhMSFT
Copy link
Contributor

LGTM

2 similar comments
@JeyJeyGao
Copy link
Contributor

LGTM

@Two-Hearts
Copy link
Contributor

LGTM

@priteshbandi
Copy link
Contributor Author

released https://github.com/notaryproject/notation-plugin-framework-go/releases/tag/v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@priteshbandi @shizhMSFT @JeyJeyGao @Two-Hearts