Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: signingAgent value needs to be updated #438

Closed
Two-Hearts opened this issue Aug 15, 2024 · 2 comments
Closed

bug: signingAgent value needs to be updated #438

Two-Hearts opened this issue Aug 15, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Two-Hearts
Copy link
Contributor

Two-Hearts commented Aug 15, 2024

What is not working as expected?

The signingAgent is still Notation/1.0.0 under the released release-1.1 branch:

const signingAgent = "Notation/1.0.0"

What did you expect to happen?

The value should be notation-go/v1.1.1.

How can we reproduce it?

During signing.

Describe your environment

All env.

What is the version of your notation-go Library?

v1.1.1

@Two-Hearts Two-Hearts added bug Something isn't working triage Needs evaluation for feasibility, timeline, etc. labels Aug 15, 2024
@shizhMSFT
Copy link
Contributor

We need to send out an PR to the main branch for RELEASE_CHECKLIST.md. Because of this field, the notation-go library requires a release process similar to notation CLI instead of notation-core-go.

Cross referencing: #437 (comment)

@yizha1 yizha1 removed the triage Needs evaluation for feasibility, timeline, etc. label Sep 3, 2024
@Two-Hearts
Copy link
Contributor Author

Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants