Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push successful but logged an error #400

Closed
JeyJeyGao opened this issue Apr 23, 2024 · 0 comments · Fixed by #402
Closed

Push successful but logged an error #400

JeyJeyGao opened this issue Apr 23, 2024 · 0 comments · Fixed by #402
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@JeyJeyGao
Copy link
Contributor

What is not working as expected?

$ notation sign --key  wabbit-networks-ca-issued $image -v
INFO Using the referrers tag schema
INFO Reference v1 resolved to manifest descriptor: {MediaType:application/vnd.docker.distribution.manifest.v2+json Digest:sha256:43837354f3f9a79b20b430b8ce4b6cc43c52dbabed9e88775b53697fe560c329 Size:1782 URLs:[] Annotations:map[] Data:[] Platform:<nil> ArtifactType:}
Warning: Always sign the artifact using digest(@sha256:...) rather than a tag(:v1) because tags are mutable and a tag reference can point to a different artifact than the one signed.
ERRO Failed to push the signature
Warning: Removal of outdated referrers index from remote registry failed. Garbage collection may be required.
Successfully signed wabbitregistry.azurecr.io/net-monitor@sha256:43837354f3f9a79b20b430b8ce4b6cc43c52dbabed9e88775b53697fe560c329

ERRO Failed to push the signature
......
Successfully signed

Which is confusing.

What did you expect to happen?

For this case:
Warning: Removal of outdated referrers index from remote registry failed. Garbage collection may be required.

We should not log an error.

How can we reproduce it?

re-sign an artifact in a registry that doesn't support deleting blob with digest

Describe your environment

Linux

What is the version of your notation-go Library?

1.1.0

@JeyJeyGao JeyJeyGao added enhancement New feature or request triage Needs evaluation for feasibility, timeline, etc. labels Apr 23, 2024
@yizha1 yizha1 removed the triage Needs evaluation for feasibility, timeline, etc. label May 7, 2024
@yizha1 yizha1 added this to the 1.2.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants