fixes #325 by updating references to The Notary Project #327

zr-msft · 2023-07-26T20:58:21Z

fixes #325

netlify · 2023-07-26T20:58:26Z

✅ Deploy Preview for notarydev ready!

Name	Link
🔨 Latest commit	`a408a79`
🔍 Latest deploy log	https://app.netlify.com/sites/notarydev/deploys/650099ee31349000080701a6
😎 Deploy Preview	https://deploy-preview-327--notarydev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

FeynmanZhou

LGTM

content/en/docs/concepts/_index.md

FeynmanZhou

PTAL

yizha1

Thanks @zr-msft

I recommend overhauling overview.md with the content from this PR notaryproject/.github#32

content/en/docs/concepts/_index.md

content/en/docs/tutorials/trust-policy.md

content/en/docs/faq.md

content/en/docs/overview.md

content/en/docs/tutorials/_index.md

content/en/docs/faq.md

zr-msft · 2023-07-28T14:38:52Z

@yizha1 and @FeynmanZhou the scope of this PR is specifically #325 which asks to update "Notary" to "The Notary Project" in the specified list of docs. I'll incorporate the targeted feedback, but the following are out of scope for this PR and should be handled in a different PR:

yizha1 · 2023-07-28T14:43:18Z

@yizha1 and @FeynmanZhou the scope of this PR is specifically #325 which asks to update "Notary" to "The Notary Project" in the specified list of docs. I'll incorporate the targeted feedback, but the following are out of scope for this PR and should be handled in a different PR:

fixes #325 by updating references to The Notary Project #327 (comment)

fixes #325 by updating references to The Notary Project #327 (review)

Thanks @zr-msft. I am OK to create a new PR to update Project Overview.

FeynmanZhou · 2023-07-28T15:56:08Z

@yizha1 and @FeynmanZhou the scope of this PR is specifically #325 which asks to update "Notary" to "The Notary Project" in the specified list of docs. I'll incorporate the targeted feedback, but the following are out of scope for this PR and should be handled in a different PR:

fixes #325 by updating references to The Notary Project #327 (comment)

fixes #325 by updating references to The Notary Project #327 (review)

@zr-msft Make sense. Feel free to raise a follow-up PR to update the project overview. We could merge this one after all comments above are resolved.

Thanks!

yizha1

Thanks @zr-msft . A few comments left.

content/en/docs/overview.md

content/en/docs/concepts/_index.md

content/en/docs/faq.md

content/en/docs/overview.md

yizha1

Suggest merging this PR after Notary Project specifications v1.0.0 is released, since we should refer to v1.0.0 specs in the documents, not main.

content/en/docs/how-to/_index.md

content/en/docs/overview.md

content/en/docs/faq.md

zr-msft · 2023-08-08T20:11:22Z

@yizha1 @FeynmanZhou @iamsamirzon incorporated/addressed your feedback

yizha1

Thanks @zr-msft I left some comments, and as discussed in this PR, I will create a new issue to overhaul the overview page

content/en/docs/how-to/_index.md

content/en/docs/faq.md

content/en/docs/overview.md

content/en/docs/faq.md

content/en/docs/overview.md

zr-msft · 2023-08-16T19:51:49Z

@yizha1 @FeynmanZhou @iamsamirzon please review when you have a chance

yizha1

Thanks @zr-msft . I just noticed that the link to specifications should point to the released version

content/en/docs/faq.md

content/en/docs/tutorials/trust-policy.md

zr-msft · 2023-08-18T16:36:13Z

thanks @yizha1, incorporated your feedback

yizha1

LGTM

yizha1 · 2023-08-19T02:26:06Z

@iamsamirzon Would you mind re-reviewing this PR? Only the version number was changed to v1.0.0 since your last approval. Thanks.

content/en/docs/faq.md

Signed-off-by: Zach Rhoads <[email protected]>

zr-msft · 2023-09-12T17:03:55Z

@yizha1 @iamsamirzon fixed and rebased. PTAL

yizha1

LGTM

zr-msft requested review from FeynmanZhou, NiazFK, iamsamirzon, justincormack, priteshbandi, SteveLasker, toddysm, vaninrao10 and yizha1 as code owners July 26, 2023 20:58

FeynmanZhou previously approved these changes Jul 27, 2023

View reviewed changes

FeynmanZhou reviewed Jul 27, 2023

View reviewed changes

content/en/docs/concepts/_index.md Outdated Show resolved Hide resolved

FeynmanZhou reviewed Jul 27, 2023

View reviewed changes

yizha1 reviewed Jul 27, 2023

View reviewed changes

yizha1 mentioned this pull request Jul 27, 2023

Proposal for bringing clarity to the Notary Project branding notaryproject/.github#35

Closed

zr-msft dismissed FeynmanZhou’s stale review via 8c6c460 July 28, 2023 19:52

zr-msft force-pushed the issue-325 branch 2 times, most recently from 8c6c460 to 6af358b Compare July 28, 2023 19:59

yizha1 reviewed Jul 30, 2023

View reviewed changes

content/en/docs/overview.md Outdated Show resolved Hide resolved

content/en/docs/overview.md Outdated Show resolved Hide resolved

iamsamirzon reviewed Jul 31, 2023

View reviewed changes

content/en/docs/concepts/_index.md Outdated Show resolved Hide resolved

iamsamirzon requested changes Jul 31, 2023

View reviewed changes

yizha1 reviewed Aug 4, 2023

View reviewed changes

content/en/docs/how-to/_index.md Outdated Show resolved Hide resolved

content/en/docs/overview.md Outdated Show resolved Hide resolved

content/en/docs/overview.md Outdated Show resolved Hide resolved

yizha1 reviewed Aug 8, 2023

View reviewed changes

content/en/docs/faq.md Outdated Show resolved Hide resolved

zr-msft force-pushed the issue-325 branch from 6af358b to 4111cc5 Compare August 8, 2023 20:10

yizha1 reviewed Aug 11, 2023

View reviewed changes

iamsamirzon reviewed Aug 15, 2023

View reviewed changes

content/en/docs/overview.md Outdated Show resolved Hide resolved

iamsamirzon previously approved these changes Aug 15, 2023

View reviewed changes

zr-msft dismissed iamsamirzon’s stale review via f33344f August 16, 2023 19:51

zr-msft force-pushed the issue-325 branch from 4111cc5 to f33344f Compare August 16, 2023 19:51

yizha1 reviewed Aug 17, 2023

View reviewed changes

content/en/docs/faq.md Outdated Show resolved Hide resolved

content/en/docs/tutorials/trust-policy.md Outdated Show resolved Hide resolved

zr-msft force-pushed the issue-325 branch from f33344f to e9fa487 Compare August 18, 2023 16:35

yizha1 previously approved these changes Aug 19, 2023

View reviewed changes

iamsamirzon reviewed Aug 22, 2023

View reviewed changes

content/en/docs/faq.md Outdated Show resolved Hide resolved

iamsamirzon reviewed Aug 22, 2023

View reviewed changes

content/en/docs/faq.md Outdated Show resolved Hide resolved

iamsamirzon reviewed Aug 22, 2023

View reviewed changes

content/en/docs/faq.md Outdated Show resolved Hide resolved

iamsamirzon requested changes Aug 22, 2023

View reviewed changes

content/en/docs/faq.md Outdated Show resolved Hide resolved

content/en/docs/faq.md Outdated Show resolved Hide resolved

zr-msft dismissed yizha1’s stale review via 2285521 September 12, 2023 16:57

zr-msft force-pushed the issue-325 branch from e9fa487 to 2285521 Compare September 12, 2023 16:57

fixes notaryproject#325 by updating references to The Notary Project

a408a79

Signed-off-by: Zach Rhoads <[email protected]>

zr-msft force-pushed the issue-325 branch from 2285521 to a408a79 Compare September 12, 2023 17:03

iamsamirzon approved these changes Sep 15, 2023

View reviewed changes

yizha1 approved these changes Sep 18, 2023

View reviewed changes

yizha1 merged commit 795aa08 into notaryproject:main Sep 18, 2023
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #325 by updating references to The Notary Project #327

fixes #325 by updating references to The Notary Project #327

zr-msft commented Jul 26, 2023 •

edited

Loading

netlify bot commented Jul 26, 2023 •

edited

Loading

FeynmanZhou left a comment

FeynmanZhou left a comment

yizha1 left a comment •

edited

Loading

zr-msft commented Jul 28, 2023

yizha1 commented Jul 28, 2023

FeynmanZhou commented Jul 28, 2023 •

edited

Loading

yizha1 left a comment

yizha1 left a comment

zr-msft commented Aug 8, 2023

yizha1 left a comment

zr-msft commented Aug 16, 2023

yizha1 left a comment

zr-msft commented Aug 18, 2023

yizha1 left a comment

yizha1 commented Aug 19, 2023

zr-msft commented Sep 12, 2023

yizha1 left a comment

fixes #325 by updating references to The Notary Project #327

fixes #325 by updating references to The Notary Project #327

Conversation

zr-msft commented Jul 26, 2023 • edited Loading

netlify bot commented Jul 26, 2023 • edited Loading

✅ Deploy Preview for notarydev ready!

FeynmanZhou left a comment

Choose a reason for hiding this comment

FeynmanZhou left a comment

Choose a reason for hiding this comment

yizha1 left a comment • edited Loading

Choose a reason for hiding this comment

zr-msft commented Jul 28, 2023

yizha1 commented Jul 28, 2023

FeynmanZhou commented Jul 28, 2023 • edited Loading

yizha1 left a comment

Choose a reason for hiding this comment

yizha1 left a comment

Choose a reason for hiding this comment

zr-msft commented Aug 8, 2023

yizha1 left a comment

Choose a reason for hiding this comment

zr-msft commented Aug 16, 2023

yizha1 left a comment

Choose a reason for hiding this comment

zr-msft commented Aug 18, 2023

yizha1 left a comment

Choose a reason for hiding this comment

yizha1 commented Aug 19, 2023

zr-msft commented Sep 12, 2023

yizha1 left a comment

Choose a reason for hiding this comment

zr-msft commented Jul 26, 2023 •

edited

Loading

netlify bot commented Jul 26, 2023 •

edited

Loading

yizha1 left a comment •

edited

Loading

FeynmanZhou commented Jul 28, 2023 •

edited

Loading