Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created glossary.md and defined project brand related terms #326

Merged
merged 8 commits into from
Aug 7, 2023

Conversation

Roseline-Bassey
Copy link
Contributor

This PR includes the following:

  • A new glossary.md page
  • It described some Notary Project terminologies such as Notary, Notation, Notary Project Specifications, and TUF.

This PR fixes #323

The difference between these terminologies would be documented in FAQ through another PR.

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit a15041b
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/64ccc6ccfef3810008ad9d4d
😎 Deploy Preview https://deploy-preview-326--notarydev.netlify.app/docs/glossary
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Roseline-Bassey . A few comments

content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
@Roseline-Bassey
Copy link
Contributor Author

Roseline-Bassey commented Jul 27, 2023

Thanks, @yizha1
I have updated this PR to address your feedback

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments left

content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
gokarnm
gokarnm previously approved these changes Aug 1, 2023
Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
zr-msft
zr-msft previously approved these changes Aug 3, 2023
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Roseline-Bassey. Left some comments.

content/en/docs/glossary.md Outdated Show resolved Hide resolved
content/en/docs/glossary.md Outdated Show resolved Hide resolved
Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamsamirzon
Copy link
Contributor

LGTM

@yizha1
Copy link
Contributor

yizha1 commented Aug 5, 2023

LGTM

@iamsamirzon Thanks for approving this PR, but it seems you need to remove "changed request", otherwise this PR cannot be merged.

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamsamirzon
Copy link
Contributor

LGTM

@yizha1 yizha1 merged commit d8d1ccd into notaryproject:main Aug 7, 2023
priteshbandi pushed a commit that referenced this pull request Aug 10, 2023
… specification, and notation (#328)

This PR adds a new section in faq.md to clarify the difference between Notary, Notary v2, Notation, TUF, and Notary Project. It fixes #323 

I haven't included a link to the `glossary page` in the last line because PR #326 is still under review and has not been merged yet. I will update this PR with the link once #326 is merged.

---------

Signed-off-by: Roseline <[email protected]>
Co-authored-by: Yi Zha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe the difference between notary, TUF, Notary Project specification, and notation in faq.md
7 participants