Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to align with TUF #1685

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

sajayantony
Copy link
Contributor

@sajayantony sajayantony commented Jun 22, 2023

The PR addresses #1684 and achieve the following

  1. Call out that the repository is scoped to the TUF implementation.
  2. Remove the upper case 'Notary' in places where it can and reference the client and server components to avoid confusion with the 'Notary Project'

Please provide feedback since I'm doing this with the best context I have and there might be areas or discussions I have missed.

@sajayantony
Copy link
Contributor Author

/cc @toddysm @iamsamirzon

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sajayantony sajayantony force-pushed the tuf_update branch 2 times, most recently from 5a4288e to 00b6d69 Compare June 23, 2023 00:16
README.md Show resolved Hide resolved
Copy link

@iamsamirzon iamsamirzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will help if we say

the year ( was it 2016 ?) when notary was released, as that will help readers date it.
explicitly state that it does not follow the specifications called out in notaryproject/notaryproject repo. ( I think we are planning to archive this repo, and when we do, we can come optionally come back and change this)

@sajayantony
Copy link
Contributor Author

I will follow up with the current state and archive comment as another PR.
I was hoping to have this focus on just calling out the pointers to TUF specification and clarify upper case Notary to notary which is this repository to unblock notaryproject/.github#35

@iamsamirzon
Copy link

LGTM But IANAM

Copy link
Contributor

@toddysm toddysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajayantony
Copy link
Contributor Author

Could we have other @notaryproject/notaryproject-notary-maintainers please help review this?

@gokarnm
Copy link

gokarnm commented Jun 27, 2023

IMO, changing Notary to lowercase notary does not make this less confusing with respect to Notary Project repo. I'd prefer keeping Notary as is, and renaming Notary Project to Notation Specifications or similar. Another option is to rename Notary Project to Specifications with Notation as a sub directory

@sajayantony
Copy link
Contributor Author

@gokarnm - The PR came about from a call to clarify in the "Notice" section that this was an implementation of TUF and there is a CLI and server. The change is scoped only to that. The reference to notary in this repo is a part of the larger issue and I'm hoping we can get the Notice section in this repo clarified and updated. This is just a very minor part of the uber issue - notaryproject/.github#35

I think we can discuss the specification repo changes in - notaryproject/.github#38

@toddysm
Copy link
Contributor

toddysm commented Jul 6, 2023

@SteveLasker and @justincormack would you mind taking a look at this PR?

@sajayantony
Copy link
Contributor Author

Pinging @notaryproject/notaryproject-notary-maintainers and this was brough up on the call.

Copy link

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we should have some folks from the TUF community/maintainers comment. This is LGTM to me.

@sajayantony
Copy link
Contributor Author

Thanks @SteveLasker.
During the call this was brought up again and the action item was the follow up with tagging the @notaryproject/notaryproject-governance-maintainers to see if we can get feedback and/or merge this.

@justincormack
Copy link
Contributor

I think some of the uses of lower case notary are a bit confusing - it doesnt really make it less confusing to be lower case. I am generally ok though.

@sajayantony
Copy link
Contributor Author

I wonder if repo owners can merge PR since this is only a readme update and I don't think it has anything to do with the CI failures.

@yizha1
Copy link
Contributor

yizha1 commented Jul 19, 2023

I wonder if repo owners can merge PR since this is only a readme update and I don't think it has anything to do with the CI failures.

@toddysm @SteveLasker do you have any suggestions? The failures of CI jobs were not related to changes to readme.md file by this PR, and probably, the main reason could be the CI and notary code are not maintained for a long time. The last merged PR in main branch was 9 months ago, and the last fix for the ci is one year ago, see 4373c53

  • ci/circleci: job_01 failed at execution of "make ci && codecov"
  • ci/circleci: job_02 failed at execution of "make ci && codecov"
  • ci/circleci: job_03 failed at execution of "make lint"
  • ci/circleci: job_04 failed at execution of "RethinkDB integration"

Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for minor typos.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Sajay Antony <[email protected]>
Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yizha1
Copy link
Contributor

yizha1 commented Jul 25, 2023

This PR was listed in issue notaryproject/.github#35 (comment), which reached a two-thirds supermajority approval. This PR itself also reached required approvals. The repo maintainers were tagged last month for reviewing this PR and addressing the failure of checks, but there has been no response till now. Since the PR only addresses the readme.md file and per the discussion of community meeting on Jul 24 PDT time, it is agreed that this PR can be merged bypass the CI checkers.

@yizha1 yizha1 merged commit c655a2f into notaryproject:master Jul 25, 2023
@sajayantony sajayantony deleted the tuf_update branch July 25, 2023 04:43
@yizha1 yizha1 linked an issue Jul 25, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the README for the repository
7 participants