-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme to align with TUF #1685
Conversation
/cc @toddysm @iamsamirzon |
5a4288e
to
00b6d69
Compare
Signed-off-by: Sajay Antony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will help if we say
the year ( was it 2016 ?) when notary was released, as that will help readers date it.
explicitly state that it does not follow the specifications called out in notaryproject/notaryproject repo. ( I think we are planning to archive this repo, and when we do, we can come optionally come back and change this)
I will follow up with the current state and archive comment as another PR. |
Signed-off-by: Sajay Antony <[email protected]>
LGTM But IANAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could we have other @notaryproject/notaryproject-notary-maintainers please help review this? |
IMO, changing |
@gokarnm - The PR came about from a call to clarify in the "Notice" section that this was an implementation of TUF and there is a CLI and server. The change is scoped only to that. The reference to I think we can discuss the specification repo changes in - notaryproject/.github#38 |
@SteveLasker and @justincormack would you mind taking a look at this PR? |
Pinging @notaryproject/notaryproject-notary-maintainers and this was brough up on the call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we should have some folks from the TUF community/maintainers comment. This is LGTM to me.
Thanks @SteveLasker. |
I think some of the uses of lower case notary are a bit confusing - it doesnt really make it less confusing to be lower case. I am generally ok though. |
I wonder if repo owners can merge PR since this is only a readme update and I don't think it has anything to do with the CI failures. |
@toddysm @SteveLasker do you have any suggestions? The failures of CI jobs were not related to changes to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for minor typos.
Signed-off-by: Sajay Antony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR was listed in issue notaryproject/.github#35 (comment), which reached a two-thirds supermajority approval. This PR itself also reached required approvals. The repo maintainers were tagged last month for reviewing this PR and addressing the failure of checks, but there has been no response till now. Since the PR only addresses the readme.md file and per the discussion of community meeting on Jul 24 PDT time, it is agreed that this PR can be merged bypass the CI checkers. |
The PR addresses #1684 and achieve the following
Please provide feedback since I'm doing this with the best context I have and there might be areas or discussions I have missed.