Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom stop sequences in settings #3061

Open
manyoso opened this issue Oct 9, 2024 · 2 comments
Open

Custom stop sequences in settings #3061

manyoso opened this issue Oct 9, 2024 · 2 comments

Comments

@manyoso
Copy link
Collaborator

manyoso commented Oct 9, 2024

  • some models output the wrong EOS token, so this is important
  • special tokens show up as blank in output because we use llama_token_to_piece with special=False, so they aren't even considered for our current hardcoded reverse prompts

Related things to fix:

@ThiloteE
Copy link
Collaborator

ThiloteE commented Oct 9, 2024

refs huggingface/transformers#28932
refs ggerganov/llama.cpp#5040

I cannot seem to find the issue/pr that talks about multiple eos in llama.cpp.

@manyoso
Copy link
Collaborator Author

manyoso commented Oct 9, 2024

Duplicate of #2439

@manyoso manyoso marked this as a duplicate of #2439 Oct 9, 2024
@manyoso manyoso closed this as completed Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Short-Term Priority List to Done in (Archived) GPT4All 2024 Roadmap and Active Issues Oct 9, 2024
@manyoso manyoso reopened this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants