Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properties in measurements should possible be called settings #28

Open
Pepe-Marquez opened this issue May 30, 2024 · 2 comments
Open

properties in measurements should possible be called settings #28

Pepe-Marquez opened this issue May 30, 2024 · 2 comments

Comments

@Pepe-Marquez
Copy link
Collaborator

Some of the Measurement entries have a sub-section called properties. This could be a confusing term, where scientists would expect physical properties derived from the measurements. A more intuitive term would be settings, to log the parameters set for the measurement.

@RoteKekse
Copy link
Collaborator

RoteKekse commented May 30, 2024

Have to check if label works for subsection, if we need to migrate the schema this is a bit of work
I still feel like property is a generic term for settings, results and all sorts of qualities but if it is confusing we should change it

@RoteKekse
Copy link
Collaborator

properties = SubSection(
        section_def=PLPropertiesLibrary, label="Settings")

works and since "an attribute, quality, or characteristic of something." is a definiton of property i think it is ok to just relabel it and not do a schema migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants