28 add md relevant outputs #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFRudzinski
force-pushed
the
28-add-md-relevant-outputs
branch
4 times, most recently
from
a282eb4 to
e5a3d7f
Compare
JFRudzinski
force-pushed
the
28-add-md-relevant-outputs
branch
from
c88cbc7 to
cc82d14
Compare
Added extraction of full_shape of the PhyiscalProperty.value from variables and tensor order
JFRudzinski
force-pushed
the
28-add-md-relevant-outputs
branch
from
8e3f5f7 to
4ce7cdf
Compare
|
@JosePizarro3 Something weird is going on here. It says that I am trying to merge into develop but the comparison displays all your property files as if I have added them myself. Is this somehow because I started this MR before the renaming? Do I need to recreate it you think? |
|
I'm going to close this and then reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JosePizarro3 @ndaelman-hu @Bernadette-Mohr I copied over a BaseProperty class that I had previously written down into
property.py. This is probably not how we want to implement things but I just wanted to share the quantities/structure that I was thinking about.Please ignore the rest of the changes.