Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for n_ quantities #144

Closed
wants to merge 3 commits into from

Conversation

ndaelman-hu
Copy link
Collaborator

No description provided.

@ndaelman-hu ndaelman-hu added the improvement/fix Improvement or fix of a previous feature label Oct 16, 2024
@ndaelman-hu ndaelman-hu marked this pull request as draft October 16, 2024 12:49
@ndaelman-hu ndaelman-hu self-assigned this Oct 16, 2024
@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11667709118

Details

  • 15 of 22 (68.18%) changed or added relevant lines in 2 files are covered.
  • 137 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-4.5%) to 75.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nomad_simulations/schema_packages/physical_property.py 12 19 63.16%
Files with Coverage Reduction New Missed Lines %
src/nomad_simulations/schema_packages/physical_property.py 3 80.68%
src/nomad_simulations/schema_packages/properties/band_gap.py 5 80.39%
src/nomad_simulations/schema_packages/properties/permittivity.py 10 62.5%
src/nomad_simulations/schema_packages/properties/greens_function.py 23 63.64%
src/nomad_simulations/schema_packages/model_system.py 25 92.11%
src/nomad_simulations/schema_packages/properties/spectral_profile.py 28 40.0%
src/nomad_simulations/schema_packages/properties/band_structure.py 43 45.6%
Totals Coverage Status
Change from base Build 11365765454: -4.5%
Covered Lines: 1918
Relevant Lines: 2537

💛 - Coveralls

…ring quantity setting

- NOTE: code will still fail when assigning `value`
@ndaelman-hu
Copy link
Collaborator Author

Cloased in favor of #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement/fix Improvement or fix of a previous feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants