Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HoppingMatrix with new schema #60

Closed
JosePizarro3 opened this issue Apr 30, 2024 · 0 comments · Fixed by #61
Closed

Fix HoppingMatrix with new schema #60

JosePizarro3 opened this issue Apr 30, 2024 · 0 comments · Fixed by #61
Assignees
@JosePizarro3
Labels
improvement/fix Improvement or fix of a previous feature

Comments

@JosePizarro3
Copy link
Collaborator

Currently, HoppingMatrix is a shared section between ModelMethod and Outputs and lives in a module common.py. However, it makes more sense to move its definition to properties/hopping_matrix.py and use the functionalities implemented for PhysicalProperty.
@JosePizarro3 JosePizarro3 added the improvement/fix Improvement or fix of a previous feature label Apr 30, 2024
@JosePizarro3 JosePizarro3 self-assigned this Apr 30, 2024
@JosePizarro3 JosePizarro3 mentioned this issue Apr 30, 2024
Merged
2 tasks
@JosePizarro3 JosePizarro3 linked a pull request Apr 30, 2024 that will close this issue
Fix HoppingMatrix with new schema #61
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JosePizarro3 JosePizarro3

Labels
improvement/fix Improvement or fix of a previous feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HoppingMatrix with new schema nomad-coe/nomad-simulations
1 participant
@JosePizarro3