Skip to content

Commit

Permalink
fixed import, remove value descriptions
Browse files Browse the repository at this point in the history
  • Loading branch information
jrudz committed Jul 3, 2024
1 parent ffdfa1a commit 0c9be48
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 10 deletions.
4 changes: 4 additions & 0 deletions src/nomad_simulations/schema_packages/physical_property.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,10 @@ class PropertyContribution(PhysicalProperty):
"""
Abstract physical property section linking a property contribution to a contribution
from some method.
Abstract class for incorporating specific contributions of a physical property, while
linking this contribution to a specific component (of class `BaseModelMethod`) of the
over `ModelMethod` using the `model_method_ref` quantity.
"""

model_method_ref = Quantity(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class BaseEnergy(PhysicalProperty):
type=np.float64,
unit='joule',
description="""
The amount of the energy.
""",
)

Expand Down
1 change: 0 additions & 1 deletion src/nomad_simulations/schema_packages/properties/forces.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class BaseForce(PhysicalProperty):
type=np.dtype(np.float64),
unit='newton',
description="""
The amount of force.
""",
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from structlog.stdlib import BoundLogger

from nomad_simulations.schema_packages.physical_property import PhysicalProperty
from nomad_simulations.schema_packages.properties import BaseEnergy
from nomad_simulations.schema_packages.properties.energies import BaseEnergy

######################################
# fundamental thermodynamic properties
Expand All @@ -47,7 +47,6 @@ class Pressure(PhysicalProperty):
type=np.float64,
unit='pascal',
description="""
The value of the pressure.
""",
)

Expand All @@ -69,7 +68,6 @@ class Volume(PhysicalProperty):
type=np.float64,
unit='m ** 3',
description="""
The value of the volume.
""",
)

Expand All @@ -86,7 +84,6 @@ class Temperature(PhysicalProperty):
type=np.float64,
unit='kelvin',
description="""
The value of the temperature.
""",
)

Expand Down Expand Up @@ -152,7 +149,6 @@ class Entropy(PhysicalProperty):
type=np.float64,
unit='joule / kelvin',
description="""
The value of the entropy.
""",
)

Expand Down Expand Up @@ -209,7 +205,6 @@ class HeatCapacity(PhysicalProperty):
type=np.float64,
unit='joule / kelvin',
description="""
The value of the heat capacity.
""",
)

Expand Down Expand Up @@ -251,7 +246,6 @@ class MassDensity(PhysicalProperty):
type=np.float64,
unit='kg / m ** 3',
description="""
The value of the mass density.
""",
)

Expand All @@ -270,7 +264,6 @@ class Hessian(PhysicalProperty):
type=np.float64,
unit='joule / m ** 2',
description="""
The value of the Hessian.
""",
)

Expand Down

1 comment on commit 0c9be48

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/nomad_simulations
   __init__.py4250%3–4
   _version.py11282%5–6
src/nomad_simulations/schema_packages
   __init__.py14286%53–55
   atoms_state.py1902189%32–34, 220–223, 247, 302–303, 371–372, 374, 556, 568–569, 630–634, 649–653, 660
   general.py75791%30–31, 99, 163, 273–274, 284
   model_method.py2657771%29–31, 190–193, 196–203, 295–296, 316, 337–356, 372–398, 401–418, 772, 783, 825–832, 870, 889, 969, 1026, 1101, 1215
   model_system.py2612292%45–47, 514–517, 565–572, 746–747, 969–973, 979–980, 988–989, 994, 1017
   numerical_settings.py2636575%32–34, 166, 236, 238–239, 242–245, 249–250, 257–260, 269–272, 276–279, 281–284, 289–292, 298–301, 472–499, 574, 609–612, 636, 639, 684, 686–689, 693, 697, 744, 748–769, 824–825, 892, 901–903, 906
   outputs.py1151091%27–28, 247–250, 290–293, 318, 320, 357, 376
   physical_property.py102793%39–41, 221, 350–352
   variables.py641183%27–29, 115, 138, 158–159, 162, 184, 207, 227
src/nomad_simulations/schema_packages/properties
   band_gap.py51590%27–29, 154–155
   band_structure.py1112280%28–30, 250–283, 296, 303, 339–340, 343
   energies.py36975%26–28, 55, 76, 101, 122, 132, 141
   fermi_surface.py17476%26–28, 59
   forces.py22673%27–29, 56, 76, 99
   hopping_matrix.py29583%26–28, 76, 111
   permittivity.py48883%26–28, 116–124
   spectral_profile.py25612452%28–30, 76–79, 114–117, 218–319, 375–387, 412–415, 435, 440–443, 485–521, 545, 592–595, 611–612, 617–623
   thermodynamics.py751876%26–28, 54, 75, 91, 100, 109, 120, 129, 156, 166, 176, 196, 212, 237, 253, 278
src/nomad_simulations/schema_packages/utils
   utils.py681479%26–28, 78–87, 96–97, 102, 105
TOTAL208744179% 

Tests Skipped Failures Errors Time
321 0 💤 19 ❌ 0 🔥 2.736s ⏱️

Please sign in to comment.