Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: 避免 outline 类名的使用 #315

Open
xsjcTony opened this issue Sep 30, 2024 · 4 comments · Fixed by #320
Open

[Bug]: 避免 outline 类名的使用 #315

xsjcTony opened this issue Sep 30, 2024 · 4 comments · Fixed by #320

Comments

@xsjcTony
Copy link

简而言之, 阅读增强 bundle 好的 css 中包含了 outline, 应该是从unocss中出来的?
它会导致VitePress这个自带的组件出现样式异常, 因为下面这部分的类名本身是 outline
Snipaste_2024-09-30_21-01-43
Snipaste_2024-09-30_21-02-17
nekomeowww added a commit that referenced this issue Oct 11, 2024
@nekomeowww
fix(enhanced-readabilities): use plain CSS styles to prevent outline …
b9e211a 
…class overrides (#315)

Signed-off-by: Neko Ayaka <[email protected]>
nekomeowww added a commit that referenced this issue Oct 11, 2024
@nekomeowww
fix(enhanced-readabilities): use plain CSS styles to prevent outline …
2434c42 
…class overrides (#315)

Signed-off-by: Neko Ayaka <[email protected]>
@nekomeowww nekomeowww mentioned this issue Oct 11, 2024
Merged
@nekomeowww
Copy link
Member

Sorry for the delayed response and fixes, will fix this on #320

nekomeowww added a commit that referenced this issue Oct 11, 2024
@nekomeowww
fix(enhanced-readabilities): use plain CSS styles to prevent outline …
a3057fc 
…class overrides (#315) (#320)

Signed-off-by: Neko Ayaka <[email protected]>
@xsjcTony
Copy link
Author

@nekomeowww This is still an issue in v2.6.1.
Mainly because the style.css file is importing @nolebase/ui/style.css, and that file includes this as well. Maybe need to fix the upstream issue.
image
Please re-open this, thanks.

@nekomeowww nekomeowww reopened this Oct 18, 2024
@nekomeowww
Copy link
Member

I think it's worth to make a dedicated CLI to help to check the unwanted classes that generated from UnoCSS. What do you think?

@nekomeowww
Copy link
Member

Just came back from little trip. Will try to resolve this ASAP. Sorry for waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nekomeowww @xsjcTony