Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch request body can be async iterable #991

Closed
ronag opened this issue Aug 20, 2021 · 2 comments
Closed

Fetch request body can be async iterable #991

ronag opened this issue Aug 20, 2021 · 2 comments
Labels
Docs Changes related to the documentation fetch good first issue Good for newcomers spec

Comments

@ronag
Copy link
Member

ronag commented Aug 20, 2021

The fetch spec does not allow async iterables as request body, we however allow it. The WHATWG doesn't seem to have anything against this per se.

Just needs to add a section in docs describing it.

whatwg/fetch#1291
@ronag ronag added good first issue Good for newcomers Docs Changes related to the documentation fetch spec labels Aug 20, 2021
@abskrj
Copy link
Contributor

abskrj commented Feb 3, 2022 •
edited
Loading

taking this

abskrj added a commit to abskrj/undici that referenced this issue Feb 3, 2022
@abskrj
feat: add asyn iterable section in doc
9b5addc 
Issue: nodejs#991

Added a description and an exmaple of async iterables in the doc
abskrj added a commit to abskrj/undici that referenced this issue Feb 3, 2022
@abskrj
feat: add asyn iterable section in doc
8e7caa4 
Issue: nodejs#991

Added a description and an exmaple of async iterables in the doc
@abskrj abskrj mentioned this issue Feb 3, 2022
Merged
ronag pushed a commit that referenced this issue Feb 4, 2022
@abskrj @KhafraDev
feat: add asyn iterable section in doc (#1202)
abf7c45 
* feat: add asyn iterable section in doc

Issue: #991

Added a description and an exmaple of async iterables in the doc

* fix: fetch method

Co-authored-by: Khafra <[email protected]>

* fix: add missing body type in readme

Co-authored-by: Khafra <[email protected]>
@RaisinTen
Copy link
Contributor

Since #1202 has landed, should we close this issue? (it didn't get automatically closed because the pr didn't use Fixes or Closes before the pr number)

@ronag ronag closed this as completed Feb 6, 2022
KhafraDev added a commit to KhafraDev/undici that referenced this issue Jun 23, 2022
@abskrj @KhafraDev
feat: add asyn iterable section in doc (nodejs#1202)
875ceb0 
* feat: add asyn iterable section in doc

Issue: nodejs#991

Added a description and an exmaple of async iterables in the doc

* fix: fetch method

Co-authored-by: Khafra <[email protected]>

* fix: add missing body type in readme

Co-authored-by: Khafra <[email protected]>
metcoder95 pushed a commit to metcoder95/undici that referenced this issue Dec 26, 2022
@abskrj @KhafraDev @metcoder95
feat: add asyn iterable section in doc (nodejs#1202)
eb2d4a3 
* feat: add asyn iterable section in doc

Issue: nodejs#991

Added a description and an exmaple of async iterables in the doc

* fix: fetch method

Co-authored-by: Khafra <[email protected]>

* fix: add missing body type in readme

Co-authored-by: Khafra <[email protected]>
crysmags pushed a commit to crysmags/undici that referenced this issue Feb 27, 2024
@abskrj @KhafraDev @crysmags
feat: add asyn iterable section in doc (nodejs#1202)
e5a442d 
* feat: add asyn iterable section in doc

Issue: nodejs#991

Added a description and an exmaple of async iterables in the doc

* fix: fetch method

Co-authored-by: Khafra <[email protected]>

* fix: add missing body type in readme

Co-authored-by: Khafra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs Changes related to the documentation fetch good first issue Good for newcomers spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ronag @abskrj @RaisinTen