Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Node.js calendar links #7098

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: Update Node.js calendar links #7098

merged 1 commit into from
Oct 8, 2024

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Oct 7, 2024

Description

Update /calendar and /calendar.ics redirects.

Validation

The endpoints should redirect to the new calendar.

Related Issues

Refs: nodejs/admin#923
Refs: nodejs/create-node-meeting-artifacts#170
Refs: nodejs/create-node-meeting-artifacts#171
Refs: #7097

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@richardlau richardlau requested a review from a team as a code owner October 7, 2024 22:51
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 7, 2024 10:51pm

@richardlau
Copy link
Member Author

cc @mhdawson @ovflowd

@richardlau
Copy link
Member Author

The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Oct 7, 2024 10:51pm

Which gives https://nodejs-org-git-updatecalendar-openjs.vercel.app/calendar as the preview link for the redirect.

Copy link

github-actions bot commented Oct 7, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Oct 7, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.308s ⏱️

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 0bef4db Oct 8, 2024
15 checks passed
@richardlau richardlau deleted the updatecalendar branch October 8, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants