-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dgram: check udp buffer size to avoid fd leak #56084
Open
theanarkh
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
theanarkh:check_buffer_size_to_avoid_fd_leak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
dgram: check udp buffer size to avoid fd leak #56084
theanarkh
wants to merge
1
commit into
nodejs:main
from
theanarkh:check_buffer_size_to_avoid_fd_leak
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
dgram
Issues and PRs related to the dgram subsystem / UDP.
needs-ci
PRs that need a full CI run.
labels
Nov 29, 2024
mcollina
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
theanarkh
force-pushed
the
check_buffer_size_to_avoid_fd_leak
branch
from
November 29, 2024 19:44
98bc860
to
37fbf6d
Compare
jasnell
approved these changes
Nov 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56084 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 656 656
Lines 188988 188995 +7
Branches 35992 35996 +4
=======================================
+ Hits 166315 166325 +10
+ Misses 15838 15836 -2
+ Partials 6835 6834 -1
|
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process will open 10 fds.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes