Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: avoid copy on getV8FastApiCallCount #56081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: avoid copy on getV8FastApiCallCount #56081

wants to merge 1 commit into from
+3 −5

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 29, 2024

Avoids copy by calling ToStringView()

@anonrig anonrig requested a review from targos November 29, 2024 17:14
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 29, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63783/

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (4efb7ae) to head (8b2d40c).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56081      +/-   ##
==========================================
+ Coverage   87.99%   88.01%   +0.01%     
==========================================
  Files         656      656              
  Lines      188988   188988              
  Branches    35988    35990       +2     
==========================================
+ Hits       166302   166332      +30     
+ Misses      15848    15827      -21     
+ Partials     6838     6829       -9

see 28 files with indirect coverage changes

@anonrig anonrig requested a review from lemire November 29, 2024 19:17
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@juanarbol juanarbol juanarbol approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@lemire lemire Awaiting requested review from lemire

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anonrig @nodejs-github-bot @jasnell @lpinca @targos @juanarbol @mertcanaltin